KnpLabs / KnpRadBundle

spec/Knp/RadBundle/Resource/Resolver/OptionsBasedSpec.php

<?php

namespace spec\Knp\RadBundle\Resource\Resolver;

use PhpSpec\ObjectBehavior;

class OptionsBasedSpec extends ObjectBehavior
{
    /**
     * @param Symfony\Component\DependencyInjection\ContainerInterface $container
     * @param Knp\RadBundle\Resource\Resolver\OptionsBased\ArgumentResolver $argumentResolver
     * @param Symfony\Component\HttpFoundation\Request $request

There is no parameter named $request. Was it maybe removed?

     * @param spec\Knp\RadBundle\Resource\Resolver\CheeseRepository $cheeseRepository
     * @param stdClass $cheese

There is no parameter named $cheese. Did you maybe mean $cheeseRepository?

     */
    function let($container, $argumentResolver, $cheeseRepository)
    {
        $this->beConstructedWith($container, $argumentResolver);
        $container->get('orm.cheese_repository')->willReturn($cheeseRepository);
    }

    /**
     * @param stdClass $cheese
     */
    function it_should_resolve_resource($request, $argumentResolver, $container, $cheese, $cheeseRepository)

The parameter $container is not used and could be removed.

Method name "OptionsBasedSpec::it_should_resolve_resource" is not in camel caps format

    {
        $argumentResolver->resolveArgument($request, array('value' => 'normandie'))->willReturn('normandie');
        $argumentResolver->resolveArgument($request, array('name' => 'slug'))->willReturn('neufchatel');

        $cheeseRepository->findByRegionAndSlug('normandie', 'neufchatel')->shouldBeCalled()->willReturn($cheese);

        $this
            ->resolveResource($request, array(
                'service'   => 'orm.cheese_repository',
                'method'    => 'findByRegionAndSlug',
                'arguments' => array(
                    array('value' => 'normandie'),
                    array('name' => 'slug'),
                )
            ))
            ->shouldReturn($cheese)
        ;
    }

    function it_should_throw_resolution_failure_when_resolved_resource_is_null($request, $argumentResolver, $cheeseRepository)

Method name "OptionsBasedSpec::it_should_throw_resolution_failure_when_resolved_resource_is_null" is not in camel caps format

    {
        $argumentResolver->resolveArgument($request, array('name' => 'slug'))->willReturn('neufchatel');
        $cheeseRepository->findBySlug('neufchatel')->willReturn(null);

        $this->shouldThrow()->duringResolveResource($request, array(
            'service'   => 'orm.cheese_repository',
            'method'    => 'findBySlug',
            'arguments' => array(
                array('name' => 'slug')
            )
        ));
    }

    function it_should_throw_exception_when_resouce_has_extra_options($request)

Method name "OptionsBasedSpec::it_should_throw_exception_when_resouce_has_extra_options" is not in camel caps format

    {
        $this->shouldThrow()->duringResolveResource($request, array(
                'extra'     => 'the extra value',
                'service'   => 'orm.cheese_repository',
                'method'    => 'findByRegionAndSlug',
                'arguments' => array(
                    array('value' => 'normandie'),
                    array('name' => 'slug'),
                ),
        ));
    }

    function it_should_throw_exception_when_resource_is_missing_service_option($request)

Method name "OptionsBasedSpec::it_should_throw_exception_when_resource_is_missing_service_option" is not in camel caps format

    {
        $this->shouldThrow()->duringResolveResource($request, array(
                'method'    => 'findByRegionAndSlug',
                'arguments' => array(
                    array('value' => 'normandie'),
                    array('name' => 'slug'),
                ),
        ));
    }

    function it_should_throw_exception_when_resource_is_missing_method_option($request)

Method name "OptionsBasedSpec::it_should_throw_exception_when_resource_is_missing_method_option" is not in camel caps format

    {
        $this->shouldThrow()->duringResolveResource($request, array(
            'service' => 'orm.cheese_repository',
            'arguments' => array(
                    array('name' => 'slug'),
            ),
        ));
    }
}

class CheeseRepository

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    public function findBySlug($slug)

The parameter $slug is not used and could be removed.

    {
    }

    public function findByRegionAndSlug($region, $slug)

The parameter $region is not used and could be removed.

The parameter $slug is not used and could be removed.

    {
    }
}