OptionsBased::__construct() - Code Metrics - KnpLabs/KnpRadBundle - Measure and Improve Code Quality continuously with Scrutinizer

OptionsBased::__construct() A
last analyzed 2016-09-14 08:09 UTC

↳ Parent: OptionsBased

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	10
nc	2
nop	2

<?php

namespace Knp\RadBundle\Resource\Resolver;

use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\OptionsResolver\OptionsResolver;
use Knp\RadBundle\Resource\Resolver\ResourceResolver;
use Knp\RadBundle\Resource\Resolver\OptionsBased\ArgumentResolver;

class OptionsBased implements ResourceResolver
{
    private $argumentResolver;
    private $optionsResolver;

    public function __construct(ContainerInterface $container, ArgumentResolver $argumentResolver = null)
    {
        $this->container = $container;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->argumentResolver = $argumentResolver ?: new ArgumentResolver;

        $this->optionsResolver = new OptionsResolver;
        $this->optionsResolver->setRequired(array('service', 'method'));
        $this->optionsResolver->setDefaults(array('arguments' => array()));
        $this->optionsResolver->setAllowedTypes(array(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'service'   => 'string',
            'method'    => 'string',
            'arguments' => 'array',
        ));
    }

    public function resolveResource(Request $request, array $options)
    {
        $options = $this->optionsResolver->resolve($options);

        $arguments = array();
        foreach ($options['arguments'] as $i => $argument) {
            if (is_string($argument)) {
                $arguments[] = $this->argumentResolver->resolveName($request, $argument);
            } else {
                try {
                    $arguments[] = $this->argumentResolver->resolveArgument($request, $argument);
                } catch (\Exception $e) {
                    throw new \RuntimeException(
                        sprintf('Failed to resolve resource argument[%s].', $i),
                        0,
                        $e
                    );
                }
            }
        }

        $service  = $this->container->get($options['service']);
        $resolved = call_user_func_array(array($service, $options['method']), $arguments);

        if (null === $resolved) {
            throw new ResolutionFailureException('The resolution resulted in a NULL value.');
        }

        return $resolved;
    }
}


1			<?php
2
3			namespace Knp\RadBundle\Resource\Resolver;
4
5			use Symfony\Component\DependencyInjection\ContainerInterface;
6			use Symfony\Component\HttpFoundation\Request;
7			use Symfony\Component\OptionsResolver\OptionsResolver;
8			use Knp\RadBundle\Resource\Resolver\ResourceResolver;
9			use Knp\RadBundle\Resource\Resolver\OptionsBased\ArgumentResolver;
10
11			class OptionsBased implements ResourceResolver
12			{
13			private $argumentResolver;
14			private $optionsResolver;
15
16			public function __construct(ContainerInterface $container, ArgumentResolver $argumentResolver = null)
17			{
18			$this->container = $container;
			0 ignored issues – show Bug introduced 2016-01-13 18:21 UTC by Report Bug Copy Issue Report The property `container` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
19			$this->argumentResolver = $argumentResolver ?: new ArgumentResolver;
20
21			$this->optionsResolver = new OptionsResolver;
22			$this->optionsResolver->setRequired(array('service', 'method'));
23			$this->optionsResolver->setDefaults(array('arguments' => array()));
24			$this->optionsResolver->setAllowedTypes(array(
			0 ignored issues – show Documentation introduced 2016-01-13 18:21 UTC by Report Bug Copy Issue Report `array('service' => 'stri...'arguments' => 'array')` is of type `array<string,string,{"se...,"arguments":"string"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
25			'service' => 'string',
26			'method' => 'string',
27			'arguments' => 'array',
28			));
29			}
30
31			public function resolveResource(Request $request, array $options)
32			{
33			$options = $this->optionsResolver->resolve($options);
34
35			$arguments = array();
36			foreach ($options['arguments'] as $i => $argument) {
37			if (is_string($argument)) {
38			$arguments[] = $this->argumentResolver->resolveName($request, $argument);
39			} else {
40			try {
41			$arguments[] = $this->argumentResolver->resolveArgument($request, $argument);
42			} catch (\Exception $e) {
43			throw new \RuntimeException(
44			sprintf('Failed to resolve resource argument[%s].', $i),
45			0,
46			$e
47			);
48			}
49			}
50			}
51
52			$service = $this->container->get($options['service']);
53			$resolved = call_user_func_array(array($service, $options['method']), $arguments);
54
55			if (null === $resolved) {
56			throw new ResolutionFailureException('The resolution resulted in a NULL value.');
57			}
58
59			return $resolved;
60			}
61			}
62

KnpLabs / KnpRadBundle

OptionsBased::__construct() A last analyzed 2016-09-14 08:09 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

OptionsBased::__construct() A
last analyzed 2016-09-14 08:09 UTC