ArgumentResolver::resolveArgument() - Code Metrics - KnpLabs/KnpRadBundle - Measure and Improve Code Quality continuously with Scrutinizer

ArgumentResolver::resolveArgument() B
last analyzed 2016-09-14 08:09 UTC

↳ Parent: ArgumentResolver

Complexity

Conditions	5
Paths	4

Size

Total Lines	25
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	25
rs	8.439
c	0
b	0
f	0
cc	5
eloc	13
nc	4
nop	2

<?php

namespace Knp\RadBundle\Resource\Resolver\OptionsBased;

use Knp\RadBundle\HttpFoundation\RequestManipulator;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\OptionsResolver\OptionsResolver;

class ArgumentResolver
{
    private $requestManipulator;
    private $optionsResolver;

    public function __construct(RequestManipulator $requestManipulator = null)
    {
        $this->requestManipulator = $requestManipulator ?: new RequestManipulator();

        $this->optionsResolver = new OptionsResolver();
        $this->optionsResolver->setOptional(array('name', 'value'));

        $this->optionsResolver->setAllowedTypes(array('name' => 'string', 'value' => 'string'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function resolveArgument(Request $request, array $options)
    {
        $options = $this->optionsResolver->resolve($options);

        $hasName = array_key_exists('name', $options);
        $hasValue = array_key_exists('value', $options);

        if ($hasName && $hasValue) {
            throw new \InvalidArgumentException(
                'You must pass either a `name` or a `value` option, but not both.'
            );
        }

        if ($hasName) {
            return $this->resolveName($request, $options['name']);
        }

        if ($hasValue) {
            return $options['value'];
        }

        throw new \InvalidArgumentException(
            'You must path either a `name` or a `value` option.'
        );
    }

    public function resolveName(Request $request, $name)
    {
        return $this->requestManipulator->getAttribute($request, $name);
    }
}


1			<?php
2
3			namespace Knp\RadBundle\Resource\Resolver\OptionsBased;
4
5			use Knp\RadBundle\HttpFoundation\RequestManipulator;
6			use Symfony\Component\HttpFoundation\Request;
7			use Symfony\Component\OptionsResolver\OptionsResolver;
8
9			class ArgumentResolver
10			{
11			private $requestManipulator;
12			private $optionsResolver;
13
14			public function __construct(RequestManipulator $requestManipulator = null)
15			{
16			$this->requestManipulator = $requestManipulator ?: new RequestManipulator();
17
18			$this->optionsResolver = new OptionsResolver();
19			$this->optionsResolver->setOptional(array('name', 'value'));
			0 ignored issues – show Deprecated Code introduced 2016-01-13 18:21 UTC by Report Bug Copy Issue Report The method `Symfony\Component\Option...Resolver::setOptional()` has been deprecated with message: since version 2.6, to be removed in 3.0. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
20			$this->optionsResolver->setAllowedTypes(array('name' => 'string', 'value' => 'string'));
			0 ignored issues – show Documentation introduced 2016-01-13 18:21 UTC by Report Bug Copy Issue Report `array('name' => 'string', 'value' => 'string')` is of type `array<string,string,{"na...ing","value":"string"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
21			}
22
23			public function resolveArgument(Request $request, array $options)
24			{
25			$options = $this->optionsResolver->resolve($options);
26
27			$hasName = array_key_exists('name', $options);
28			$hasValue = array_key_exists('value', $options);
29
30			if ($hasName && $hasValue) {
31			throw new \InvalidArgumentException(
32			'You must pass either a `name` or a `value` option, but not both.'
33			);
34			}
35
36			if ($hasName) {
37			return $this->resolveName($request, $options['name']);
38			}
39
40			if ($hasValue) {
41			return $options['value'];
42			}
43
44			throw new \InvalidArgumentException(
45			'You must path either a `name` or a `value` option.'
46			);
47			}
48
49			public function resolveName(Request $request, $name)
50			{
51			return $this->requestManipulator->getAttribute($request, $name);
52			}
53			}
54

KnpLabs / KnpRadBundle

ArgumentResolver::resolveArgument() B last analyzed 2016-09-14 08:09 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ArgumentResolver::resolveArgument() B
last analyzed 2016-09-14 08:09 UTC