spec\Knp\RadBundle\View\NameDeducerSpec

Complexity

Total Complexity

4

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	2
Bugs	1	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	let()	0	8	1
A	it_should_deduce_standard_controller_names()	0	9	1
A	it_should_deduce_service_controller_names()	0	10	1
A	it_should_use_view_attribute_if_given()	0	8	1

<?php

namespace spec\Knp\RadBundle\View;

use PhpSpec\ObjectBehavior;

class NameDeducerSpec extends ObjectBehavior
{
    /**
     * @param Symfony\Component\DependencyInjection\ContainerInterface               $container
     * @param Symfony\Component\HttpFoundation\Request                               $request
     * @param Symfony\Bundle\FrameworkBundle\Templating\EngineInterface              $engine
     * @param Symfony\Bundle\FrameworkBundle\Controller\ControllerNameParser         $cnp
     * @param Knp\RadBundle\HttpFoundation\RequestManipulator                        $reqManip
     * @param Knp\RadBundle\AppBundle\BundleGuesser                                  $bundleGuesser
     * @param Symfony\Component\HttpKernel\Bundle\BundleInterface                    $bundle
     */
    function let($container, $request, $engine, $cnp, $reqManip, $bundleGuesser, $bundle)

The parameter $request is not used and could be removed.

    {
        $bundleGuesser->hasBundleForClass(\Prophecy\Argument::any())->willReturn(true);
        $bundleGuesser->getBundleForClass(\Prophecy\Argument::any())->willReturn($bundle);
        $bundle->getName()->willReturn('App');

        $this->beConstructedWith($container, $engine, $cnp, $bundleGuesser, $reqManip,  'twig');

Expected 1 space instead of 2 after comma in function call.

    }

    function it_should_deduce_standard_controller_names($request, $reqManip, $engine)

The parameter $engine is not used and could be removed.

Method name "NameDeducerSpec::it_should_deduce_standard_controller_names" is not in camel caps format

    {
        $reqManip->hasAttribute($request, 'view')->willReturn(false);
        $reqManip->hasAttribute($request, '_controller')->willReturn(true);
        $reqManip->getAttribute($request, '_controller')->willReturn('App\Controller\CheeseController::eatAction');
        $request->getRequestFormat()->willReturn('html');

        $this->deduce($request)->shouldReturn('App:Cheese:eat.html.twig');
    }

    function it_should_deduce_service_controller_names($container, $request, $reqManip, $engine)

The parameter $engine is not used and could be removed.

Method name "NameDeducerSpec::it_should_deduce_service_controller_names" is not in camel caps format

    {
        $reqManip->hasAttribute($request, 'view')->willReturn(false);
        $reqManip->hasAttribute($request, '_controller')->willReturn(true);
        $reqManip->getAttribute($request, '_controller')->willReturn('app.controller.assistant:eatAction');
        $container->get('app.controller.assistant')->willReturn(new \Knp\RadBundle\Controller\AssistantController);
        $request->getRequestFormat()->willReturn('html');

        $this->deduce($request)->shouldReturn('App:Assistant:eat.html.twig');
    }

    function it_should_use_view_attribute_if_given($request, $reqManip, $engine)

The parameter $engine is not used and could be removed.

Method name "NameDeducerSpec::it_should_use_view_attribute_if_given" is not in camel caps format

    {
        $reqManip->hasAttribute($request, 'view')->willReturn(true);
        $reqManip->getAttribute($request, 'view')->willReturn('App:Cheese:eat');
        $request->getRequestFormat()->willReturn('html');

        $this->deduce($request)->shouldReturn('App:Cheese:eat.html.twig');
    }
}