spec\Knp\RadBundle\Resource\Resolver\ExpressionLanguageBasedSpec

Complexity

Total Complexity

2

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	let()	0	6	1
A	its_resolveResource_uses_ExpressionLanguage()	0	6	1

<?php

namespace spec\Knp\RadBundle\Resource\Resolver;

use PhpSpec\ObjectBehavior;
use Prophecy\Argument;

class ExpressionLanguageBasedSpec extends ObjectBehavior
{
    /**
     * @param Symfony\Component\DependencyInjection\ContainerInterface $container
     * @param Symfony\Component\HttpFoundation\Request $request
     * @param Symfony\Component\HttpFoundation\ParameterBag $attributes
     * @param spec\Knp\RadBundle\Resource\Resolver\CakeRepository $cakeRepository
     * @param stdClass $cake
     */
    function let($container, $request, $cakeRepository, $attributes, $cake)

The parameter $cake is not used and could be removed.

    {
        $this->beConstructedWith($container);
        $container->get('orm.cake_repository')->willReturn($cakeRepository);
        $request->attributes = $attributes;
    }

    function its_resolveResource_uses_ExpressionLanguage($request, $attributes, $cake, $cakeRepository)

Method name "ExpressionLanguageBasedSpec::its_resolveResource_uses_ExpressionLanguage" is not in camel caps format

    {
        $attributes->get('test')->willReturn('value!');
        $cakeRepository->findBySlug('value!')->shouldBeCalled()->willReturn($cake);
        $this->resolveResource($request, array('expr' => "service('orm.cake_repository').findBySlug(request.attributes.get('test'))"))->shouldReturn($cake);
    }
}

class CakeRepository

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    public function findBySlug($slug)

The parameter $slug is not used and could be removed.

    {
    }

    public function findByRegionAndSlug($region, $slug)

The parameter $region is not used and could be removed.

The parameter $slug is not used and could be removed.

    {
    }
}