Knp\RadBundle\Routing\Conventional\Config\Factory

Complexity

Total Complexity

9

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	2
A	all()	0	14	3
A	get()	0	19	4

<?php

namespace Knp\RadBundle\Routing\Conventional\Config;

use Knp\RadBundle\Routing\Conventional\Config;

class Factory
{
    private $parser;
    private $index = array();

    public function __construct(Parser $parser = null)
    {
        $this->parser = $parser ?: new Parser;
    }

    public function all($path)
    {
        $rawConfigs = $this->parser->parse($path);
        if (empty($rawConfigs)) {
            return array();
        }

        $all = array();
        foreach ($rawConfigs as $name => $rawConfig) {

The expression $rawConfigs of type string|array|object<stdClass> is not guaranteed to be traversable. How about adding an additional type check?

            $all[] = $this->get($name, $rawConfigs);
        }

        return $all;
    }

    private function get($name, array $rawConfigs)
    {
        if (isset($this->index[$name])) {
            return $this->index[$name];
        }
        if (!array_key_exists($name, $rawConfigs)) {
            throw new \InvalidArgumentException(
                sprintf('no "%s" in [%s]', $name, implode(', ', array_keys($rawConfigs)))
            );
        }
        $rawConfig = $rawConfigs[$name];
        $parent = null;
        if (isset($rawConfig['parent'])) {
            $parentCollection = $this->get($rawConfig['parent'], $rawConfigs);
            $parent = $parentCollection->getRepresentant();
        }

        return $this->index[$name] = new Config($name, $rawConfig, $parent);
    }
}