LocalTest::setUp() - Code Metrics - Inspection of "Move Local adapter into his own namespace" - KnpLabs/Gaufrette - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#433)

by Albin

created 2016-11-16 21:30 UTC

LocalTest::setUp() A

↳ Parent: LocalTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	0

<?php

namespace Gaufrette\Adapter\Local\Functional\FileStream;

use Gaufrette\Adapter\Local\Local;
use Gaufrette\Filesystem;
use Gaufrette\Functional\FileStream\FunctionalTestCase;

class LocalTest extends FunctionalTestCase
{
    protected $directory;

    public function setUp()
    {
        $this->directory = __DIR__.DIRECTORY_SEPARATOR.'filesystem';
        @mkdir($this->directory.DIRECTORY_SEPARATOR.'subdir', 0777, true);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        $this->filesystem = new Filesystem(new Local($this->directory, true));

        $this->registerLocalFilesystemInStream();
    }

    public function tearDown()
    {
        if (is_dir($this->directory)) {
            (new \Symfony\Component\Filesystem\Filesystem())->remove($this->directory);
        }
    }

    /**
     * @test
     */
    public function shouldSupportsDirectory()
    {
        $this->assertTrue(file_exists('gaufrette://filestream/subdir'));
        $this->assertTrue(is_dir('gaufrette://filestream/subdir'));
    }
}


1			<?php
2
3			namespace Gaufrette\Adapter\Local\Functional\FileStream;
4
5			use Gaufrette\Adapter\Local\Local;
6			use Gaufrette\Filesystem;
7			use Gaufrette\Functional\FileStream\FunctionalTestCase;
8
9			class LocalTest extends FunctionalTestCase
10			{
11			protected $directory;
12
13			public function setUp()
14			{
15			$this->directory = __DIR__.DIRECTORY_SEPARATOR.'filesystem';
16			@mkdir($this->directory.DIRECTORY_SEPARATOR.'subdir', 0777, true);
			0 ignored issues – show Security Best Practice introduced 2016-11-16 21:41 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
17			$this->filesystem = new Filesystem(new Local($this->directory, true));
18
19			$this->registerLocalFilesystemInStream();
20			}
21
22			public function tearDown()
23			{
24			if (is_dir($this->directory)) {
25			(new \Symfony\Component\Filesystem\Filesystem())->remove($this->directory);
26			}
27			}
28
29			/**
30			* @test
31			*/
32			public function shouldSupportsDirectory()
33			{
34			$this->assertTrue(file_exists('gaufrette://filestream/subdir'));
35			$this->assertTrue(is_dir('gaufrette://filestream/subdir'));
36			}
37			}
38

KnpLabs / Gaufrette

Pull Request — master (#433)

LocalTest::setUp() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like