Knp\FriendlyContexts\Alice\Fixtures\Loader

Complexity

Total Complexity

6

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getCache()	0	4	1
A	clearCache()	0	4	1
A	load()	0	4	1
A	instantiateFixtures()	0	12	2

<?php

namespace Knp\FriendlyContexts\Alice\Fixtures;

use Knp\FriendlyContexts\Alice\ProviderResolver;
use Nelmio\Alice\Loader\NativeLoader as BaseLoader;

class Loader extends BaseLoader
{
    private $cache = [];

Consider using a different property name as you override a private property of the parent class.

    public function __construct($locale, ProviderResolver $providers)
    {
        parent::__construct($locale, $providers->all());

The call to NativeLoader::__construct() has too many arguments starting with $providers->all().

    }

    public function getCache()
    {
        return $this->cache;
    }

    public function clearCache()
    {
        $this->cache = [];
    }

    public function load($filename)
    {
        return $this->loadFile($filename);
    }

    /**
     * {@inheritdoc}
     */
    protected function instantiateFixtures(array $fixtures)
    {
        parent::instantiateFixtures($fixtures);

It seems like you code against a specific sub-type and not the parent class Nelmio\Alice\Loader\NativeLoader as the method instantiateFixtures() does only exist in the following sub-classes of Nelmio\Alice\Loader\NativeLoader: Knp\FriendlyContexts\Alice\Fixtures\Loader. Maybe you want to instanceof check for one of these explicitly?

        foreach ($fixtures as $fixture) {
            $spec = array_map(function ($property) {
                return $property->getValue();
            }, $fixture->getProperties());

            $this->cache[] = [ $spec, $this->objects->get($fixture->getName()) ];

The property objects does not exist. Did you maybe forget to declare it?

        }
    }
}