Knp\FriendlyContexts\Builder\AbstractRequestBuilder

Complexity

Total Complexity

4

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	2
A	getRequestFactory()	0	4	1
A	getClient()	0	4	1

<?php

namespace Knp\FriendlyContexts\Builder;

use Http\Client\HttpClient;
use Http\Discovery\HttpClientDiscovery;
use Http\Message\RequestFactory;

abstract class AbstractRequestBuilder implements RequestBuilderInterface
{
    /**
     * @var RequestFactory
     */
    protected $requestFactory;

    /**
     * @var HttpClient
     */
    protected $client;

    /**
     * @param RequestFactory $requestFactory
     * @param HttpClient     $client

Should the type for parameter $client not be null|HttpClient?

     */
    public function __construct(RequestFactory $requestFactory, HttpClient $client = null)
    {
        $this->requestFactory = $requestFactory;
        $this->client = $client ?: HttpClientDiscovery::find();

Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space

    }

    public function getRequestFactory()
    {
        return $this->requestFactory;
    }

    public function getClient()
    {
        return $this->client;
    }
}