Person::supportsParent()   A
last analyzed

Complexity

Conditions 1
Paths 1

Size

Total Lines 4
Code Lines 2

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 4
rs 10
c 0
b 0
f 0
cc 1
eloc 2
nc 1
nop 1
1
<?php
2
3
namespace Knp\FriendlyContexts\Faker\Provider;
4
5
class Person extends Base
6
{
7
    public function fullname()
0 ignored issues
show
Documentation introduced by
The return type could not be reliably inferred; please add a @return annotation.

Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a @return annotation as described here.

Loading history...
8
    {
9
        return $this->parent->name();
0 ignored issues
show
Bug introduced by
It seems like you code against a specific sub-type and not the parent class Faker\Provider\Base as the method name() does only exist in the following sub-classes of Faker\Provider\Base: Faker\Provider\Person, Faker\Provider\ar_JO\Person, Faker\Provider\ar_SA\Person, Faker\Provider\bg_BG\Person, Faker\Provider\bn_BD\Person, Faker\Provider\cs_CZ\Person, Faker\Provider\da_DK\Person, Faker\Provider\de_AT\Person, Faker\Provider\de_CH\Person, Faker\Provider\de_DE\Person, Faker\Provider\el_GR\Person, Faker\Provider\en_GB\Person, Faker\Provider\en_IN\Person, Faker\Provider\en_UG\Person, Faker\Provider\en_US\Person, Faker\Provider\en_ZA\Person, Faker\Provider\es_AR\Person, Faker\Provider\es_ES\Person, Faker\Provider\es_PE\Person, Faker\Provider\es_VE\Person, Faker\Provider\fa_IR\Person, Faker\Provider\fi_FI\Person, Faker\Provider\fr_BE\Person, Faker\Provider\fr_CA\Person, Faker\Provider\fr_CH\Person, Faker\Provider\fr_FR\Person, Faker\Provider\he_IL\Person, Faker\Provider\hr_HR\Person, Faker\Provider\hu_HU\Person, Faker\Provider\hy_AM\Person, Faker\Provider\id_ID\Person, Faker\Provider\is_IS\Person, Faker\Provider\it_CH\Person, Faker\Provider\it_IT\Person, Faker\Provider\ja_JP\Person, Faker\Provider\ka_GE\Person, Faker\Provider\kk_KZ\Person, Faker\Provider\ko_KR\Person, Faker\Provider\lt_LT\Person, Faker\Provider\lv_LV\Person, Faker\Provider\me_ME\Person, Faker\Provider\mn_MN\Person, Faker\Provider\nb_NO\Person, Faker\Provider\ne_NP\Person, Faker\Provider\nl_BE\Person, Faker\Provider\nl_NL\Person, Faker\Provider\pl_PL\Person, Faker\Provider\pt_BR\Person, Faker\Provider\pt_PT\Person, Faker\Provider\ro_MD\Person, Faker\Provider\ro_RO\Person, Faker\Provider\ru_RU\Person, Faker\Provider\sk_SK\Person, Faker\Provider\sl_SI\Person, Faker\Provider\sr_Cyrl_RS\Person, Faker\Provider\sr_Latn_RS\Person, Faker\Provider\sr_RS\Person, Faker\Provider\sv_SE\Person, Faker\Provider\tr_TR\Person, Faker\Provider\uk_UA\Person, Faker\Provider\vi_VN\Person, Faker\Provider\zh_CN\Person, Faker\Provider\zh_TW\Person. Maybe you want to instanceof check for one of these explicitly?

Let’s take a look at an example:

abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the parent class:

    abstract class User
    {
        /** @return string */
        abstract public function getPassword();
    
        /** @return string */
        abstract public function getDisplayName();
    }
    
Loading history...
10
    }
11
12
    public function supportsParent($parent)
13
    {
14
        return $parent instanceOf \Faker\Provider\Person;
15
    }
16
}
17