DictionaryValidator::varToString() - Code Metrics - Inspection of "test: configure scrutinizer" - KnpLabs/DictionaryBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#149)

by Pierre

created 2021-01-29 15:41 UTC

DictionaryValidator::varToString() B

↳ Parent: DictionaryValidator

Complexity

Conditions	7
Paths	7

Size

Total Lines	22
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	7

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
cc	7
eloc	11
c	1
b	1
f	0
nc	7
nop	1
dl	0
loc	22
ccs	12
cts	12
cp	1
crap	7
rs	8.8333

<?php

declare(strict_types=1);

namespace Knp\DictionaryBundle\Validator\Constraints;

use Knp\DictionaryBundle\Dictionary\Collection;
use Symfony\Component\Form\Exception\UnexpectedTypeException;
use Symfony\Component\Validator\Constraint;
use Symfony\Component\Validator\ConstraintValidator;

final class DictionaryValidator extends ConstraintValidator
{
    /**
     * @var Collection
     */
    private $dictionaries;

    public function __construct(Collection $dictionaries)
    {
        $this->dictionaries = $dictionaries;
    }

    public function validate($value, Constraint $constraint): void
    {
        if (!$constraint instanceof Dictionary) {
            throw new UnexpectedTypeException($constraint, __NAMESPACE__.'\Dictionary');
        }

        if (null === $value || '' === $value) {
            return;
        }

        $dictionary = $this->dictionaries[$constraint->name];
        $values     = $dictionary->getKeys();

        if (!\in_array($value, $values, true)) {
            $this->context->addViolation(
                $constraint->message,
                [
                    '{{ key }}'  => $this->varToString($value),
                    '{{ keys }}' => implode(
                        ', ',
                        array_map(
                            [$this, 'varToString'],
                            $values
                        )
                    ),
                ]
            );
        }
    }

    /**
     * @param mixed $var
     */
    private function varToString($var): string
    {
        if (null === $var) {
            return 'null';
        }

        if (\is_string($var)) {
            return '"'.$var.'"';
        }

        if (\is_bool($var)) {
            return $var ? 'true' : 'false';
        }

        if (\is_float($var)) {
            return 0.0 === $var

                ? '0.0'
                : (string) $var
            ;
        }

        return (string) $var;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Knp\DictionaryBundle\Validator\Constraints;
6
7		use Knp\DictionaryBundle\Dictionary\Collection;
8		use Symfony\Component\Form\Exception\UnexpectedTypeException;
9		use Symfony\Component\Validator\Constraint;
10		use Symfony\Component\Validator\ConstraintValidator;
11
12		final class DictionaryValidator extends ConstraintValidator
13		{
14		/**
15		* @var Collection
16		*/
17		private $dictionaries;
18
19	5	public function __construct(Collection $dictionaries)
20		{
21	5	$this->dictionaries = $dictionaries;
22	5	}
23
24	4	public function validate($value, Constraint $constraint): void
25		{
26	4	if (!$constraint instanceof Dictionary) {
27	1	throw new UnexpectedTypeException($constraint, __NAMESPACE__.'\Dictionary');
28		}
29
30	3	if (null === $value \|\| '' === $value) {
31		return;
32		}
33
34	3	$dictionary = $this->dictionaries[$constraint->name];
35	3	$values = $dictionary->getKeys();
36
37	3	if (!\in_array($value, $values, true)) {
38	2	$this->context->addViolation(
39	2	$constraint->message,
40		[
41	2	'{{ key }}' => $this->varToString($value),
42	2	'{{ keys }}' => implode(
43	2	', ',
44	2	array_map(
45	2	[$this, 'varToString'],
46		$values
47		)
48		),
49		]
50		);
51		}
52	3	}
53
54		/**
55		* @param mixed $var
56		*/
57	2	private function varToString($var): string
58		{
59	2	if (null === $var) {
60	1	return 'null';
61		}
62
63	2	if (\is_string($var)) {
64	2	return '"'.$var.'"';
65		}
66
67	1	if (\is_bool($var)) {
68	1	return $var ? 'true' : 'false';
69		}
70
71	1	if (\is_float($var)) {
72	1	return 0.0 === $var
		0 ignored issues – show introduced 2021-01-29 15:44 UTC by Report Bug Copy Issue Report The condition `0.0 === $var` is always `false`. Loading history...
73	1	? '0.0'
74	1	: (string) $var
75		;
76		}
77
78	1	return (string) $var;
79		}
80		}
81

KnpLabs / DictionaryBundle

Pull Request — master (#149)

DictionaryValidator::varToString() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like