Extended::create() - Code Metrics - Inspection of "test: configure scrutinizer" - KnpLabs/DictionaryBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#149)

by Pierre

created 2021-01-29 15:41 UTC

Extended::create() A

↳ Parent: Extended

Complexity

Conditions	2
Paths	2

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2.032

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
cc	2
eloc	10
c	3
b	0
f	0
nc	2
nop	2
dl	0
loc	17
ccs	8
cts	10
cp	0.8
crap	2.032
rs	9.9332

<?php

declare(strict_types=1);

namespace Knp\DictionaryBundle\Dictionary\Factory;

use InvalidArgumentException;
use Knp\DictionaryBundle\Dictionary;
use Knp\DictionaryBundle\Dictionary\Collection;
use Knp\DictionaryBundle\Dictionary\Combined;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Knp\DictionaryBundle\Dictionary\Factory;

final class Extended implements Factory
{
    /**
     * @var Dictionary\Factory
     */
    private $factory;

    /**
     * @var Dictionary\Collection
     */
    private $dictionaries;

    public function __construct(Factory $factory, Collection $dictionaries)
    {
        $this->factory      = $factory;
        $this->dictionaries = $dictionaries;
    }

    public function create(string $name, array $config): Dictionary
    {
        if (!$this->factory->supports($config)) {
            throw new InvalidArgumentException(sprintf(
                'The dictionary with named "%s" cannot be created.',
                $name
            ));
        }

        $extends = $config['extends'];

        unset($config['extends']);

        return new Combined(
            $name,
            $this->dictionaries[$extends],
            $this->factory->create($name, $config)
        );
    }

    public function supports(array $config): bool
    {
        return isset($config['extends']);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Knp\DictionaryBundle\Dictionary\Factory;
6
7		use InvalidArgumentException;
8		use Knp\DictionaryBundle\Dictionary;
9		use Knp\DictionaryBundle\Dictionary\Collection;
10		use Knp\DictionaryBundle\Dictionary\Combined;
		0 ignored issues – show Bug introduced 2021-01-29 15:44 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Knp\DictionaryBundle\Dictionary\Factory\Combined`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
11		use Knp\DictionaryBundle\Dictionary\Factory;
12
13		final class Extended implements Factory
14		{
15		/**
16		* @var Dictionary\Factory
17		*/
18		private $factory;
19
20		/**
21		* @var Dictionary\Collection
22		*/
23		private $dictionaries;
24
25	4	public function __construct(Factory $factory, Collection $dictionaries)
26		{
27	4	$this->factory = $factory;
28	4	$this->dictionaries = $dictionaries;
29	4	}
30
31	1	public function create(string $name, array $config): Dictionary
32		{
33	1	if (!$this->factory->supports($config)) {
34		throw new InvalidArgumentException(sprintf(
35		'The dictionary with named "%s" cannot be created.',
36		$name
37		));
38		}
39
40	1	$extends = $config['extends'];
41
42	1	unset($config['extends']);
43
44	1	return new Combined(
45	1	$name,
46	1	$this->dictionaries[$extends],
47	1	$this->factory->create($name, $config)
48		);
49		}
50
51	1	public function supports(array $config): bool
52		{
53	1	return isset($config['extends']);
54		}
55		}
56

KnpLabs / DictionaryBundle

Pull Request — master (#149)

Extended::create() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like