Combined::__construct() - Code Metrics - Inspection of "test: configure scrutinizer" - KnpLabs/DictionaryBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#149)

by Pierre

created 2021-01-29 15:41 UTC

Combined::__construct() A

↳ Parent: Combined

Complexity

Conditions	2
Paths	1

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	6
c	1
b	0
f	0
nc	1
nop	2
dl	0
loc	11
ccs	7
cts	7
cp	1
crap	2
rs	10

<?php

declare(strict_types=1);

namespace Knp\DictionaryBundle\Dictionary;

use Knp\DictionaryBundle\Dictionary;

/**
 * @template E
 * @extends Wrapper<E>
 */
final class Combined extends Wrapper
{
    /**
     * @param Dictionary<E> ...$dictionaries
     */
    public function __construct(string $name, Dictionary ...$dictionaries)
    {
        parent::__construct(
            new Invokable($name, function () use ($dictionaries) {
                $data = [];

                foreach ($dictionaries as $dictionary) {
                    $data = $this->merge($data, iterator_to_array($dictionary));
                }

                return $data;
            })
        );
    }

    /**
     * @param E[] $array1
     * @param E[] $array2
     *
     * @return E[]
     */
    private function merge(array $array1, array $array2): array
    {
        if ($array1 === array_values($array1) && $array2 === array_values($array2)) {
            return array_merge($array1, $array2);
        }

        $data = [];

        foreach ([$array1, $array2] as $array) {
            foreach ($array as $key => $value) {
                $data[$key] = $value;
            }
        }

        return $data;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Knp\DictionaryBundle\Dictionary;
6
7		use Knp\DictionaryBundle\Dictionary;
8
9		/**
10		* @template E
11		* @extends Wrapper<E>
12		*/
13		final class Combined extends Wrapper
14		{
15		/**
16		* @param Dictionary<E> ...$dictionaries
17		*/
18	9	public function __construct(string $name, Dictionary ...$dictionaries)
19		{
20	9	parent::__construct(
21	9	new Invokable($name, function () use ($dictionaries) {
22	6	$data = [];
23
24	6	foreach ($dictionaries as $dictionary) {
25	6	$data = $this->merge($data, iterator_to_array($dictionary));
26		}
27
28	6	return $data;
29	9	})
30		);
31	9	}
32
33		/**
34		* @param E[] $array1
35		* @param E[] $array2
36		*
37		* @return E[]
38		*/
39	6	private function merge(array $array1, array $array2): array
40		{
41	6	if ($array1 === array_values($array1) && $array2 === array_values($array2)) {
42	1	return array_merge($array1, $array2);
43		}
44
45	5	$data = [];
46
47	5	foreach ([$array1, $array2] as $array) {
48	5	foreach ($array as $key => $value) {
49	5	$data[$key] = $value;
50		}
51		}
52
53	5	return $data;
54		}
55		}
56

KnpLabs / DictionaryBundle

Pull Request — master (#149)

Combined::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like