spec\Knp\DictionaryBundle\Dictionary\CollectionSpec

Complexity

Total Complexity

10

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	it_is_countable()	0	3	1
A	it_should_entry_if_it_exists()	0	4	1
A	its_offsetUnset_method_cannot_be_called()	0	3	1
A	it_is_initializable()	0	3	1
A	it_counts_entries()	0	3	1
A	its_offsetSet_method_cannot_be_called()	0	3	1
A	it_is_iterable()	0	3	1
A	let()	0	5	1
A	it_is_an_array_access()	0	3	1
A	it_is_a_list_ob_dictionaries()	0	5	1

<?php

declare(strict_types=1);

namespace spec\Knp\DictionaryBundle\Dictionary;

use ArrayAccess;
use Countable;
use IteratorAggregate;
use Knp\DictionaryBundle\Dictionary;
use Knp\DictionaryBundle\Dictionary\Collection;
use PhpSpec\ObjectBehavior;
use RuntimeException;

final class CollectionSpec extends ObjectBehavior
{
    function let(Dictionary $dictionary, Dictionary $dictionary2)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->beConstructedWith($dictionary, $dictionary2);
        $dictionary->getName()->willReturn('foo');
        $dictionary2->getName()->willReturn('dictionary');
    }

    function it_is_initializable()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->shouldHaveType(Collection::class);
    }

    function it_is_an_array_access()
    {
        $this->shouldHaveType(ArrayAccess::class);
    }

    function it_is_iterable()
    {
        $this->shouldHaveType(IteratorAggregate::class);
    }

    function it_is_countable()
    {
        $this->shouldHaveType(Countable::class);
    }

    function it_should_entry_if_it_exists($dictionary)

The parameter $dictionary is not used and could be removed.

    {
        $this->offsetExists('foo')->shouldBe(true);
        $this->offsetExists('baz')->shouldBe(false);
    }

    function it_counts_entries()
    {
        $this->count()->shouldReturn(2);

The method count() does not exist on spec\Knp\DictionaryBundle\Dictionary\CollectionSpec. Since you implemented __call, consider adding a @method annotation.

    }

    function it_is_a_list_ob_dictionaries($dictionary, $dictionary2)
    {
        $this->getIterator()->getArrayCopy()->shouldReturn([

The method getIterator() does not exist on spec\Knp\DictionaryBundle\Dictionary\CollectionSpec. Since you implemented __call, consider adding a @method annotation.

            'foo'        => $dictionary,
            'dictionary' => $dictionary2,
        ]);
    }

    function its_offsetSet_method_cannot_be_called()
    {
        $this->shouldThrow(RuntimeException::class)->duringOffsetSet('foo', 'bar');
    }

    function its_offsetUnset_method_cannot_be_called()
    {
        $this->shouldThrow(RuntimeException::class)->duringOffsetUnset('foo');
    }
}