spec\Knp\DictionaryBundle\DependencyInjection\Compiler\DictionaryRegistrationPassSpec

Complexity

Total Complexity

2

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	it_is_initializable()	0	3	1
A	it_registers_dictionaries()	0	20	1

<?php

declare(strict_types=1);

namespace spec\Knp\DictionaryBundle\DependencyInjection\Compiler;

use Knp\DictionaryBundle\DependencyInjection\Compiler\DictionaryRegistrationPass;
use Knp\DictionaryBundle\Dictionary\Collection;
use PhpSpec\ObjectBehavior;
use Prophecy\Argument;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Definition;

final class DictionaryRegistrationPassSpec extends ObjectBehavior
{
    function it_is_initializable()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->shouldHaveType(DictionaryRegistrationPass::class);
    }

    function it_registers_dictionaries(ContainerBuilder $container, Definition $dictionaries)
    {
        $tags = ['foo' => [], 'bar' => [], 'baz' => []];

        $container->getDefinition(Collection::class)->willReturn($dictionaries);

The method willReturn() does not exist on Symfony\Component\DependencyInjection\Definition.

        $container->findTaggedServiceIds(DictionaryRegistrationPass::TAG_DICTIONARY)->willReturn($tags);

        $dictionaries->addMethodCall('add', Argument::that(function (array $arguments): bool {

Prophecy\Argument::that(function(...) { /* ... */ }) of type Prophecy\Argument\Token\CallbackToken is incompatible with the type array expected by parameter $arguments of Symfony\Component\DependencyInjection\Definition::addMethodCall().

            return 'foo' === $arguments[0]->__toString();
        }))->shouldBeCalled();

The method shouldBeCalled() does not exist on Symfony\Component\DependencyInjection\Definition.

        $dictionaries->addMethodCall('add', Argument::that(function (array $arguments): bool {
            return 'bar' === $arguments[0]->__toString();
        }))->shouldBeCalled();

        $dictionaries->addMethodCall('add', Argument::that(function (array $arguments): bool {
            return 'baz' === $arguments[0]->__toString();
        }))->shouldBeCalled();

        $this->process($container);

The method process() does not exist on spec\Knp\DictionaryBundle\DependencyInjection\Compiler\DictionaryRegistrationPassSpec. Since you implemented __call, consider adding a @method annotation.

    }
}