Extended::supports()   A
last analyzed

Complexity

Conditions 1
Paths 1

Size

Total Lines 3
Code Lines 1

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 2

Importance

Changes 1
Bugs 0 Features 0
Metric Value
cc 1
eloc 1
c 1
b 0
f 0
nc 1
nop 1
dl 0
loc 3
ccs 0
cts 0
cp 0
crap 2
rs 10
1
<?php
2
3
declare(strict_types=1);
4
5
namespace Knp\DictionaryBundle\Dictionary\Factory;
6
7
use Knp\DictionaryBundle\Dictionary;
8
use Knp\DictionaryBundle\Dictionary\Collection;
9
use Knp\DictionaryBundle\Dictionary\Combined;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, Knp\DictionaryBundle\Dictionary\Factory\Combined. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
10
use Knp\DictionaryBundle\Dictionary\Factory;
11
12
final class Extended implements Factory
13
{
14
    public function __construct(private readonly Factory $factory, private Collection $collection) {}
15
16
    public function create(string $name, array $config): Dictionary
17
    {
18
        if (!$this->factory->supports($config)) {
19
            throw new \InvalidArgumentException(\sprintf(
20
                'The dictionary with named "%s" cannot be created.',
21
                $name
22
            ));
23
        }
24
25 4
        $extends = $config['extends'];
26
27 4
        unset($config['extends']);
28 4
29 4
        return new Combined(
30
            $name,
31 1
            $this->collection[$extends],
32
            $this->factory->create($name, $config)
33 1
        );
34
    }
35
36
    public function supports(array $config): bool
37
    {
38
        return isset($config['extends']);
39
    }
40
}
41