spec\Knp\DictionaryBundle\ValueTransformer\ConstantSpec

Complexity

Total Complexity

7

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	it_transforms_constant_patterns()	0	3	1
A	it_supports_existing_classes_and_constants()	0	3	1
A	it_doesnt_support_integers()	0	3	1
A	it_doesnt_support_non_constant_pattern_values()	0	3	1
A	it_is_initializable()	0	3	1
A	it_doesnt_support_non_existing_constants()	0	3	1
A	it_doesnt_support_non_existing_classes()	0	3	1

<?php

declare(strict_types=1);

namespace spec\Knp\DictionaryBundle\ValueTransformer;

use Knp\DictionaryBundle\Dictionary;
use Knp\DictionaryBundle\ValueTransformer\Constant;
use PhpSpec\ObjectBehavior;

final class ConstantSpec extends ObjectBehavior
{
    function it_is_initializable()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->shouldHaveType(Constant::class);
    }

    function it_doesnt_support_non_constant_pattern_values()
    {
        $this->supports('foo')->shouldReturn(false);

The method supports() does not exist on spec\Knp\DictionaryBundle\ValueTransformer\ConstantSpec. Since you implemented __call, consider adding a @method annotation.

    }

    function it_doesnt_support_integers()
    {
        $this->supports(0)->shouldReturn(false);
    }

    function it_doesnt_support_non_existing_classes()
    {
        $this->supports('My\Awesome\Non\Existing\Class::CONST')->shouldReturn(false);
    }

    function it_doesnt_support_non_existing_constants()
    {
        $this->supports(Dictionary::class.'::PONEY')->shouldReturn(false);
    }

    function it_supports_existing_classes_and_constants()
    {
        $this->supports(Dictionary::class.'::VALUE')->shouldReturn(true);
    }

    function it_transforms_constant_patterns()
    {
        $this->transform(Dictionary::class.'::VALUE')->shouldReturn('value');

The method transform() does not exist on spec\Knp\DictionaryBundle\ValueTransformer\ConstantSpec. Since you implemented __call, consider adding a @method annotation.

    }
}