spec\Knp\DictionaryBundle\Dictionary\IteratorSpec

Complexity

Total Complexity

12

Size/Duplication

Total Lines	107
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	execution()	0	15	2
A	it_is_hydrated_just_once()	0	12	1
A	it_provides_a_set_of_values()	0	6	1
A	it_supports_some_array_access_functions()	0	12	1
A	its_getname_should_return_dictionary_name()	0	3	1
A	let()	0	5	1
A	it_generates_an_iterator()	0	6	1
A	it_is_initializable()	0	3	1
A	it_provides_a_set_of_keys()	0	6	1
A	it_access_to_value_like_an_array()	0	5	1
A	it_is_a_dictionary()	0	3	1

<?php

declare(strict_types=1);

namespace spec\Knp\DictionaryBundle\Dictionary;

use Knp\DictionaryBundle\Dictionary;
use Knp\DictionaryBundle\Dictionary\Iterator;
use PhpSpec\ObjectBehavior;

final class IteratorSpec extends ObjectBehavior
{
    /**
     * @var bool
     */
    private $executed;

    function let()
    {
        $this->executed = false;

        $this->beConstructedWith('foo', $this->execution());
    }

    function it_is_initializable()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->shouldHaveType(Iterator::class);
    }

    function it_is_a_dictionary()
    {
        $this->shouldImplement(Dictionary::class);
    }

    function it_supports_some_array_access_functions()
    {
        $dictionary = $this->getWrappedObject();

        $this['foo']->shouldBe(0);
        $this->shouldHaveKey('foo');

        $this['foo'] = 'test';
        $this['foo']->shouldBe('test');

        unset($dictionary['foo']);
        $this->shouldNotHaveKey('foo');
    }

    function it_provides_a_set_of_values()
    {
        $this->getValues()->shouldReturn([

The method getValues() does not exist on spec\Knp\DictionaryBundle\Dictionary\IteratorSpec. Since you implemented __call, consider adding a @method annotation.

            'foo' => 0,
            'bar' => 1,
            'baz' => 2,
        ]);
    }

    function it_provides_a_set_of_keys()
    {
        $this->getKeys()->shouldReturn([

The method getKeys() does not exist on spec\Knp\DictionaryBundle\Dictionary\IteratorSpec. Since you implemented __call, consider adding a @method annotation.

            'foo',
            'bar',
            'baz',
        ]);
    }

    function it_is_hydrated_just_once()
    {
        $this->getValues()->shouldReturn([
            'foo' => 0,
            'bar' => 1,
            'baz' => 2,
        ]);

        $this->getValues()->shouldReturn([
            'foo' => 0,
            'bar' => 1,
            'baz' => 2,
        ]);
    }

    function it_access_to_value_like_an_array()
    {
        $this['foo']->shouldReturn(0);
        $this['bar']->shouldReturn(1);
        $this['baz']->shouldReturn(2);
    }

    function it_generates_an_iterator()
    {
        $this->shouldIterateLike([
            'foo' => 0,
            'bar' => 1,
            'baz' => 2,
        ]);
    }

    function its_getname_should_return_dictionary_name()
    {
        $this->getName()->shouldReturn('foo');

The method getName() does not exist on spec\Knp\DictionaryBundle\Dictionary\IteratorSpec. Since you implemented __call, consider adding a @method annotation.

    }

    private function execution(): iterable
    {
        if (!$this->executed) {
            $this->executed = true;

            yield 'foo' => 0;

            yield 'bar' => 1;

            yield 'baz' => 2;

            return;
        }

        throw new \Exception('Executed twice.');
    }
}