spec\Knp\DictionaryBundle\Dictionary\Factory\ValueSpec

Complexity

Total Complexity

6

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	it_is_a_factory()	0	3	1
A	it_throws_exception_if_no_content_is_provided()	0	5	1
A	it_creates_a_dictionary()	0	14	1
A	it_is_initializable()	0	3	1
A	it_supports_specific_config()	0	3	1
A	let()	0	3	1

<?php

declare(strict_types=1);

namespace spec\Knp\DictionaryBundle\Dictionary\Factory;

use Knp\DictionaryBundle\Dictionary\Factory;
use Knp\DictionaryBundle\Dictionary\Factory\Value;
use Knp\DictionaryBundle\ValueTransformer;
use PhpSpec\ObjectBehavior;

final class ValueSpec extends ObjectBehavior
{
    function let(ValueTransformer $transformer)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->beConstructedWith($transformer);
    }

    function it_is_initializable()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->shouldHaveType(Value::class);
    }

    function it_is_a_factory()
    {
        $this->shouldHaveType(Factory::class);
    }

    function it_supports_specific_config()
    {
        $this->supports(['type' => 'value'])->shouldReturn(true);

The method supports() does not exist on spec\Knp\DictionaryBundle\Dictionary\Factory\ValueSpec. Since you implemented __call, consider adding a @method annotation.

    }

    function it_throws_exception_if_no_content_is_provided()
    {
        $this
            ->shouldThrow(\InvalidArgumentException::class)
            ->during('create', ['yolo', []])
        ;
    }

    function it_creates_a_dictionary($transformer)
    {
        $config = [
            'content' => ['bar1', 'bar2', 'bar3'],
        ];

        $transformer->transform('bar1')->willReturn('bar1');
        $transformer->transform('bar2')->willReturn('bar2');
        $transformer->transform('bar3')->willReturn('bar3');

        $dictionary = $this->create('yolo', $config);

The method create() does not exist on spec\Knp\DictionaryBundle\Dictionary\Factory\ValueSpec. Since you implemented __call, consider adding a @method annotation.

        $dictionary->getName()->shouldBe('yolo');
        $dictionary->getValues()->shouldBe(['bar1', 'bar2', 'bar3']);
    }
}