spec\Knp\DictionaryBundle\Dictionary\Factory\IteratorSpec

Complexity

Total Complexity

5

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	let()	0	3	1
A	it_is_initializable()	0	3	1
A	it_creates_a_dictionary()	0	20	1
A	it_is_a_factory()	0	3	1
A	it_supports_specific_config()	0	3	1

<?php

declare(strict_types=1);

namespace spec\Knp\DictionaryBundle\Dictionary\Factory;

use Knp\DictionaryBundle\Dictionary\Factory;
use Knp\DictionaryBundle\Dictionary\Factory\Iterator;
use PhpSpec\ObjectBehavior;
use Symfony\Component\DependencyInjection\Container;

final class IteratorSpec extends ObjectBehavior
{
    function let(Container $container)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->beConstructedWith($container);
    }

    function it_is_initializable()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->shouldHaveType(Iterator::class);
    }

    function it_is_a_factory()
    {
        $this->shouldHaveType(Factory::class);
    }

    function it_supports_specific_config()
    {
        $this->supports(['type' => 'iterator'])->shouldReturn(true);

The method supports() does not exist on spec\Knp\DictionaryBundle\Dictionary\Factory\IteratorSpec. Since you implemented __call, consider adding a @method annotation.

    }

    function it_creates_a_dictionary($container, MockIterator $service)
    {
        $config = [
            'service' => 'service.id',
        ];

        $container->get('service.id')->willReturn($service);
        $service->getIterator()->willReturn(new \ArrayIterator([

The method willReturn() does not exist on Traversable. It seems like you code against a sub-type of Traversable such as RectorPrefix202509\Nette\Utils\ArrayList or RectorPrefix202509\Nette\Utils\Finder or RectorPrefix202509\Nette\Utils\Html or RectorPrefix202509\Nette\Iterators\CachingIterator.

            'foo1' => 'bar1',
            'foo2' => 'bar2',
            'foo3' => 'bar3',
        ]));

        $dictionary = $this->create('yolo', $config);

The method create() does not exist on spec\Knp\DictionaryBundle\Dictionary\Factory\IteratorSpec. Since you implemented __call, consider adding a @method annotation.

        $dictionary->getName()->shouldBe('yolo');
        $dictionary->getValues()->shouldBe([
            'foo1' => 'bar1',
            'foo2' => 'bar2',
            'foo3' => 'bar3',
        ]);
    }
}

abstract class MockIterator implements \IteratorAggregate
{
    public function getIterator()
    {
        return yield from [];
    }
}