spec\Knp\DictionaryBundle\Dictionary\Factory\InvokableSpec

Complexity

Total Complexity

5

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	it_is_initializable()	0	3	1
A	it_is_a_factory()	0	3	1
A	let()	0	3	1
A	it_supports_specific_config()	0	3	1
A	it_creates_a_dictionary()	0	21	1

<?php

declare(strict_types=1);

namespace spec\Knp\DictionaryBundle\Dictionary\Factory;

use Knp\DictionaryBundle\Dictionary\Factory;
use Knp\DictionaryBundle\Dictionary\Factory\Invokable;
use PhpSpec\ObjectBehavior;
use Symfony\Component\DependencyInjection\Container;

final class InvokableSpec extends ObjectBehavior
{
    function let(Container $container)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->beConstructedWith($container);
    }

    function it_is_initializable()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->shouldHaveType(Invokable::class);
    }

    function it_is_a_factory()
    {
        $this->shouldHaveType(Factory::class);
    }

    function it_supports_specific_config()
    {
        $this->supports(['type' => 'callable'])->shouldReturn(true);

The method supports() does not exist on spec\Knp\DictionaryBundle\Dictionary\Factory\InvokableSpec. Since you implemented __call, consider adding a @method annotation.

    }

    function it_creates_a_dictionary($container, MockInvokable $service)
    {
        $config = [
            'service' => 'service.id',
            'method'  => 'getYolo',
        ];

        $container->get('service.id')->willReturn($service);
        $service->getYolo()->willReturn([
            'foo1' => 'bar1',
            'foo2' => 'bar2',
            'foo3' => 'bar3',
        ]);

        $dictionary = $this->create('yolo', $config);

The method create() does not exist on spec\Knp\DictionaryBundle\Dictionary\Factory\InvokableSpec. Since you implemented __call, consider adding a @method annotation.

        $dictionary->getName()->shouldBe('yolo');
        $dictionary->getValues()->shouldBe([
            'foo1' => 'bar1',
            'foo2' => 'bar2',
            'foo3' => 'bar3',
        ]);
    }
}

abstract class MockInvokable
{
    /**
     * @return mixed[]
     */
    public function getYolo(): array
    {
        return [];
    }
}