spec\Knp\DictionaryBundle\Dictionary\Factory\ExtendedSpec

Complexity

Total Complexity

5

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	it_creates_a_dictionary()	0	25	1
A	let()	0	3	1
A	it_is_initializable()	0	3	1
A	it_supports_specific_config()	0	3	1
A	it_is_a_factory()	0	3	1

<?php

declare(strict_types=1);

namespace spec\Knp\DictionaryBundle\Dictionary\Factory;

use Knp\DictionaryBundle\Dictionary;
use Knp\DictionaryBundle\Dictionary\Collection;
use Knp\DictionaryBundle\Dictionary\Factory;
use Knp\DictionaryBundle\Dictionary\Factory\Extended;
use PhpSpec\ObjectBehavior;

final class ExtendedSpec extends ObjectBehavior
{
    function let(Factory $factory)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->beConstructedWith($factory, new Collection());
    }

    function it_is_initializable()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->shouldHaveType(Extended::class);
    }

    function it_is_a_factory()
    {
        $this->shouldHaveType(Factory::class);
    }

    function it_supports_specific_config()
    {
        $this->supports(['extends' => 'my_dictionary'])->shouldReturn(true);

The method supports() does not exist on spec\Knp\DictionaryBundle\Dictionary\Factory\ExtendedSpec. Since you implemented __call, consider adding a @method annotation.

    }

    function it_creates_a_dictionary($factory, Dictionary $initialDictionary, Dictionary $extendsDictionary)
    {
        $initialDictionary->getName()->willReturn('initial_dictionary');
        $initialDictionary->getIterator()->willReturn(new \ArrayIterator(['foo1', 'foo2']));

The method willReturn() does not exist on Traversable. It seems like you code against a sub-type of Traversable such as RectorPrefix202506\Nette\Utils\Finder or RectorPrefix202506\Nette\Utils\Html or RectorPrefix202506\Nette\Utils\ArrayList or RectorPrefix202506\Nette\Iterators\CachingIterator.

        $extendsDictionary->getName()->willReturn('extends_dictionary');
        $extendsDictionary->getIterator()->willReturn(new \ArrayIterator(['bar1', 'bar2', 'bar3']));

        $dictionaries = new Collection($initialDictionary->getWrappedObject(), $extendsDictionary->getWrappedObject());

The method getWrappedObject() does not exist on Knp\DictionaryBundle\Dictionary.

        $this->beConstructedWith($factory, $dictionaries);

        $config = [
            'content' => ['bar1', 'bar2', 'bar3'],
        ];

        $factory->create('yolo', $config)->willReturn($extendsDictionary);

        $config = array_merge($config, ['extends' => 'initial_dictionary']);
        $factory->supports($config)->willReturn(true);

        $dictionary = $this->create('yolo', $config);

The method create() does not exist on spec\Knp\DictionaryBundle\Dictionary\Factory\ExtendedSpec. Since you implemented __call, consider adding a @method annotation.

        $dictionary->getName()->shouldBe('yolo');
        $dictionary->getValues()->shouldBe(['foo1', 'foo2', 'bar1', 'bar2', 'bar3']);
    }
}