spec\Knp\DictionaryBundle\DependencyInjection\Compiler\DictionaryFactoryBuildingPassSpec

Complexity

Total Complexity

3

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	it_is_initializable()	0	3	1
A	it_adds_tagged_services_into_factory_aggregate()	0	31	2

<?php

declare(strict_types=1);

namespace spec\Knp\DictionaryBundle\DependencyInjection\Compiler;

use Knp\DictionaryBundle\DependencyInjection\Compiler\DictionaryFactoryBuildingPass;
use Knp\DictionaryBundle\Dictionary\Factory\Aggregate;
use PhpSpec\ObjectBehavior;
use Prophecy\Argument;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Definition;
use Symfony\Component\DependencyInjection\Reference;

final class DictionaryFactoryBuildingPassSpec extends ObjectBehavior
{
    function it_is_initializable()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->shouldHaveType(DictionaryFactoryBuildingPass::class);
    }

    function it_adds_tagged_services_into_factory_aggregate(
        ContainerBuilder $container,
        Definition $factory1,
        Definition $factory2,
        Definition $factory3,
        Definition $aggregate,
        Definition $definition
    ) {
        $container
            ->findTaggedServiceIds(DictionaryFactoryBuildingPass::TAG_FACTORY)
            ->willReturn([
                'factory1' => $factory1,
                'factory2' => $factory2,
                'factory3' => $factory3,
            ])
        ;

        $container
            ->findDefinition(Aggregate::class)
            ->willReturn($aggregate)

The method willReturn() does not exist on Symfony\Component\DependencyInjection\Definition.

        ;

        foreach (['factory1', 'factory2', 'factory3'] as $id) {
            $aggregate
                ->addMethodCall('addFactory', Argument::exact([new Reference($id)]))

Prophecy\Argument::exact(array(new Symfony\Component\DependencyInjection\Reference($id))) of type Prophecy\Argument\Token\ExactValueToken is incompatible with the type array expected by parameter $arguments of Symfony\Component\DependencyInjection\Definition::addMethodCall().

                ->shouldBeCalledTimes(1)

The method shouldBeCalledTimes() does not exist on Symfony\Component\DependencyInjection\Definition.

                ->willReturn($definition)
            ;
        }

        $this->process($container);

The method process() does not exist on spec\Knp\DictionaryBundle\DependencyInjection\Compiler\DictionaryFactoryBuildingPassSpec. Since you implemented __call, consider adding a @method annotation.

    }
}