Knp\DictionaryBundle\Dictionary\Combined

Complexity

Total Complexity

7

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	merge()	0	15	5
A	__construct()	0	11	2

<?php

declare(strict_types=1);

namespace Knp\DictionaryBundle\Dictionary;

use Knp\DictionaryBundle\Dictionary;

/**
 * @template E
 *
 * @extends Wrapper<E>
 */
final class Combined extends Wrapper
{
    /**
     * @param Dictionary<E> ...$dictionaries
     */
    public function __construct(string $name, Dictionary ...$dictionaries)
    {
        parent::__construct(
            new Invokable($name, function () use ($dictionaries): array {
                $data = [];

                foreach ($dictionaries as $dictionary) {
                    $data = $this->merge($data, iterator_to_array($dictionary));
                }

                return $data;
            })
        );
    }

    /**
     * @param E[] $array1
     * @param E[] $array2
     *
     * @return E[]
     */
    private function merge(array $array1, array $array2): array
    {
        if ($array1 === array_values($array1) && $array2 === array_values($array2)) {
            return [...$array1, ...$array2];

The expression return array($array1, $array2) returns the type array<integer,Knp\DictionaryBundle\Dictionary\E[]> which is incompatible with the documented return type Knp\DictionaryBundle\Dictionary\E[].

        }

        $data = [];

        foreach ([$array1, $array2] as $array) {
            foreach ($array as $key => $value) {
                $data[$key] = $value;
            }
        }

        return $data;
    }
}