CFDI::getXSL() - Code Metrics - Inspection of "Add getXSL method" - Kinedu/cfdi-xml - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c1ba37...00354c )

by Orlando

created 2018-02-09 22:33 UTC

CFDI::getXSL() A

↳ Parent: CFDI

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	0

<?php

/*
 * This file is part of the cfdi-xml project.
 *
 * (c) Kinedu
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Kinedu\CfdiXML;

use Kinedu\CfdiXML\Node\Comprobante;
use Kinedu\CfdiXML\Common\Node;
use XSLTProcessor;
use DOMDocument;

class CFDI
{
    /**
     * SAT XSL endpoint.
     *
     * @var string
     */
    const XSL_ENDPOINT = 'http://www.sat.gob.mx/sitio_internet/cfd/3/cadenaoriginal_3_3/cadenaoriginal_3_3.xslt';

    /**
     * CFDI version.
     *
     * @var string
     */
    protected $version = '3.3';

    /**
     * CSD key.
     *
     * @var string
     */
    protected $key;

    /**
     * CSD cer.
     *
     * @var string
     */
    protected $cer;

    /**
     * Comprobante instance.
     *
     * @var \Kinedu\CfdiXML\Node\Comprobante
     */
    protected $comprobante;

    /**
     * Create a new cfdi instance.
     *
     * @param array $data
     * @param string $key
     * @param string $cer
     */
    public function __construct(array $data, string $key, string $cer)
    {
        $this->comprobante = new Comprobante($data, $this->version);

        $this->key = file_get_contents($key);
        $this->cer = file_get_contents($cer);
    }

    /**
     * Add new node to comprobante instance.
     *
     * @param \Kinedu\CfdiXML\Common\Node $node
     *
     * @return void
     */
    public function add(Node $node)
    {
        $this->comprobante->add($node);
    }

    /**
     * Gets the original string.
     *
     * @return string
     */
    public function getCadenaOriginal() : string
    {
        $xsl = new DOMDocument();
        $xsl->load($this->getXSL());

        $xslt = new XSLTProcessor();
        @$xslt->importStyleSheet($xsl);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        $xml = new DOMDocument();
        $xml->loadXML($this->comprobante->getDocument()->saveXML());

        return (string) $xslt->transformToXml($xml);
    }

    /**
     * Get sello.
     *
     * @return string
     */
    public function getSello() : string
    {
        $pkey = openssl_get_privatekey($this->key);
        openssl_sign(@$this->getCadenaOriginal(), $signature, $pkey, OPENSSL_ALGO_SHA256);
        openssl_free_key($pkey);
        return base64_encode($signature);
    }

    /**
     * Put sello.
     *
     * @return void
     */
    protected function putSello()
    {
        $this->comprobante->setAttr(
            $this->comprobante->getElement(),
            [
                'Sello' => $this->getSello(),
            ]
        );
    }

    /**
     * Get certificado.
     *
     * @return string
     */
    public function getCertificado() : string
    {
        $cer = preg_replace('/(-+[^-]+-+)/', '', $this->cer);
        $cer = preg_replace('/\s+/', '', $cer);
        return $cer;
    }

    /**
     * Put certificado.
     *
     * @return void
     */
    protected function putCertificado()
    {
        $this->comprobante->setAttr(
            $this->comprobante->getElement(),
            [
                'Certificado' => $this->getCertificado(),
            ]
        );
    }

    /**
     * Returns the xml with the stamp and certificate attributes.
     *
     * @return DOMDocument
     */
    protected function xml() : DOMDocument
    {
        $this->putSello();
        $this->putCertificado();
        return $this->comprobante->getDocument();
    }

    /**
     * Get the xml.
     *
     * @return string
     */
    public function getXML() : string
    {
        return $this->xml()->saveXML();
    }

    /**
     * @param string $filename
     */
    public function save(string $filename)
    {
        return $this->xml()->save($filename);
    }

    /**
     * @return string
     */
    public function getXSL()
    {
        $file = './xslt/cadenaoriginal_3_3.xslt';

        if (file_exists($file)) {
            return $file;
        }

        return static::XSL_ENDPOINT;
    }
}


1			<?php
2
3			/*
4			* This file is part of the cfdi-xml project.
5			*
6			* (c) Kinedu
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Kinedu\CfdiXML;
13
14			use Kinedu\CfdiXML\Node\Comprobante;
15			use Kinedu\CfdiXML\Common\Node;
16			use XSLTProcessor;
17			use DOMDocument;
18
19			class CFDI
20			{
21			/**
22			* SAT XSL endpoint.
23			*
24			* @var string
25			*/
26			const XSL_ENDPOINT = 'http://www.sat.gob.mx/sitio_internet/cfd/3/cadenaoriginal_3_3/cadenaoriginal_3_3.xslt';
27
28			/**
29			* CFDI version.
30			*
31			* @var string
32			*/
33			protected $version = '3.3';
34
35			/**
36			* CSD key.
37			*
38			* @var string
39			*/
40			protected $key;
41
42			/**
43			* CSD cer.
44			*
45			* @var string
46			*/
47			protected $cer;
48
49			/**
50			* Comprobante instance.
51			*
52			* @var \Kinedu\CfdiXML\Node\Comprobante
53			*/
54			protected $comprobante;
55
56			/**
57			* Create a new cfdi instance.
58			*
59			* @param array $data
60			* @param string $key
61			* @param string $cer
62			*/
63			public function __construct(array $data, string $key, string $cer)
64			{
65			$this->comprobante = new Comprobante($data, $this->version);
66
67			$this->key = file_get_contents($key);
68			$this->cer = file_get_contents($cer);
69			}
70
71			/**
72			* Add new node to comprobante instance.
73			*
74			* @param \Kinedu\CfdiXML\Common\Node $node
75			*
76			* @return void
77			*/
78			public function add(Node $node)
79			{
80			$this->comprobante->add($node);
81			}
82
83			/**
84			* Gets the original string.
85			*
86			* @return string
87			*/
88			public function getCadenaOriginal() : string
89			{
90			$xsl = new DOMDocument();
91			$xsl->load($this->getXSL());
92
93			$xslt = new XSLTProcessor();
94			@$xslt->importStyleSheet($xsl);
			0 ignored issues – show Security Best Practice introduced 2018-02-07 17:15 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
95
96			$xml = new DOMDocument();
97			$xml->loadXML($this->comprobante->getDocument()->saveXML());
98
99			return (string) $xslt->transformToXml($xml);
100			}
101
102			/**
103			* Get sello.
104			*
105			* @return string
106			*/
107			public function getSello() : string
108			{
109			$pkey = openssl_get_privatekey($this->key);
110			openssl_sign(@$this->getCadenaOriginal(), $signature, $pkey, OPENSSL_ALGO_SHA256);
111			openssl_free_key($pkey);
112			return base64_encode($signature);
113			}
114
115			/**
116			* Put sello.
117			*
118			* @return void
119			*/
120			protected function putSello()
121			{
122			$this->comprobante->setAttr(
123			$this->comprobante->getElement(),
124			[
125			'Sello' => $this->getSello(),
126			]
127			);
128			}
129
130			/**
131			* Get certificado.
132			*
133			* @return string
134			*/
135			public function getCertificado() : string
136			{
137			$cer = preg_replace('/(-+[^-]+-+)/', '', $this->cer);
138			$cer = preg_replace('/\s+/', '', $cer);
139			return $cer;
140			}
141
142			/**
143			* Put certificado.
144			*
145			* @return void
146			*/
147			protected function putCertificado()
148			{
149			$this->comprobante->setAttr(
150			$this->comprobante->getElement(),
151			[
152			'Certificado' => $this->getCertificado(),
153			]
154			);
155			}
156
157			/**
158			* Returns the xml with the stamp and certificate attributes.
159			*
160			* @return DOMDocument
161			*/
162			protected function xml() : DOMDocument
163			{
164			$this->putSello();
165			$this->putCertificado();
166			return $this->comprobante->getDocument();
167			}
168
169			/**
170			* Get the xml.
171			*
172			* @return string
173			*/
174			public function getXML() : string
175			{
176			return $this->xml()->saveXML();
177			}
178
179			/**
180			* @param string $filename
181			*/
182			public function save(string $filename)
183			{
184			return $this->xml()->save($filename);
185			}
186
187			/**
188			* @return string
189			*/
190			public function getXSL()
191			{
192			$file = './xslt/cadenaoriginal_3_3.xslt';
193
194			if (file_exists($file)) {
195			return $file;
196			}
197
198			return static::XSL_ENDPOINT;
199			}
200			}
201

Kinedu / cfdi-xml

GitHub Access Token became invalid

Push — master ( c1ba37...00354c )

CFDI::getXSL() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like