Kinedu\CfdiPac\PACSoapRequest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	81
Duplicated Lines	11.11 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	9	9	1
	makeRequest()	0	1	?
	getXML()	0	1	?
A	save()	0	9	1

<?php

/*
 * This file is part of the cfdi-certificate project.
 *
 * (c) Kinedu
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Kinedu\CfdiPac;

use DOMDocument;

abstract class PACSoapRequest
{
    /**
     * Client username.
     *
     * @var string
     */
    protected $username;

    /**
     * Client password.
     *
     * @var string
     */
    protected $password;

    /**
     * CFDI XML.
     *
     * @var string
     */
    protected $xml;

    /**
     * @param bool
     */
    protected $test;

    /** @var array */
    protected $options = [
        'soap_version' => SOAP_1_2,
        'trace' => 1,
    ];

    /**
     * Create a new invoice one strategy instance.
     *
     * @param  string  $username
     * @param  string  $password
     * @param  string  $xml
     * @param  bool  $test
     */
    public function __construct(string $username, string $password, string $xml, bool $test = false)

This method seems to be duplicated in your project.

    {
        $this->username = $username;
        $this->password = $password;
        $this->xml = $xml;
        $this->test = $test;

        return $this;

Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct?

    }

    /**
     * Soap request.
     *
     * @return mixed
     */
    abstract protected function makeRequest();

    /**
     * Returns the cfdi with the TFD node.
     *
     * @return string
     */
    abstract public function getXML();

    /**
     * @param string $filename
     *
     * @return integer
     */
    public function save(string $filename)
    {
        $xml = new DOMDocument();
        $xml->preserveWhiteSpace = true;
        $xml->formatOutput = true;
        $xml->loadXML($this->getXML());

        return $xml->save($filename);
    }
}