Certificate::getFileExstensionName() - Code Metrics - Inspection of "Add strategy in construct" - Kinedu/cfdi-certificate - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7bc96a...a2e938 )

by Orlando

created 2018-02-19 19:06 UTC

Certificate::getFileExstensionName() A

↳ Parent: Certificate

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

/*
 * This file is part of the cfdi-certificate project.
 *
 * (c) Kinedu
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Kinedu\CfdiCertificate;

use Kinedu\CfdiCertificate\Strategies\CerStrategy;
use Kinedu\CfdiCertificate\Strategies\KeyStrategy;
use Kinedu\CfdiCertificate\IO;
use Exception;

class Certificate
{
    /**
     * File to decode.
     *
     * @var string
     */
    protected $file;

    /**
     * Password to the decode the file.
     *
     * @var string
     */
    protected $password;

    /**
     * @var string
     */
    protected $strategy;

    /**
     * Create a new certificate instance.
     *
     * @param string $file
     * @param string $password
     * @param string $strategy
     */
    public function __construct(string $file, string $password = null, string $strategy = null)
    {
        $this->file = new IO($file);

        $this->password = $password;
        $this->strategy = $strategy;
    }

    /**
     * @return CerStrategy|KeyStrategy|null
     */
    protected function getStrategy()
    {
        switch ($this->getFileExstensionName()) {
            case 'cer':
                $strategy = new CerStrategy(
                    $this->file->getOrginalRoute()

                );
            break;

            case 'key':
                $strategy = new KeyStrategy(
                    $this->file->getOrginalRoute(),

                    $this->password
                );
            break;
        }

        return $strategy;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    /**
     * @return string
     */
    public function decode() : string
    {
        $strategy = $this->getStrategy();
        $pem = $strategy->convertToPem();

        return $pem;
    }

    /**
     * @param string $directory
     * @param string $filename
     *
     * @return integer|bool
     */
    public function save(string $directory, string $filename = null)
    {
        $filename  = $filename ?? $this->file->getFileName();

        $extension = $this->getFileExstensionName();

        $directory = rtrim($directory, '/').'/';
        $directory = "{$directory}{$filename}.{$extension}.pem";

        return file_put_contents($directory, $this->decode());
    }

    /**
     * @param string $name
     * @param array $arguments
     */
    public function __call(string $name, array $arguments)
    {
        $strategy = $this->getStrategy();

        if (method_exists($strategy, $name)) {
            return $strategy->{$name}($arguments);
        } else {
            throw new Exception("This method doesn't exist");
        }
    }

    /**
     * @return string
     */
    protected function getFileExstensionName()
    {
        return $this->strategy ?? $this->file->getFileExstensionName();

    }
}


1			<?php
2
3			/*
4			* This file is part of the cfdi-certificate project.
5			*
6			* (c) Kinedu
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Kinedu\CfdiCertificate;
13
14			use Kinedu\CfdiCertificate\Strategies\CerStrategy;
15			use Kinedu\CfdiCertificate\Strategies\KeyStrategy;
16			use Kinedu\CfdiCertificate\IO;
17			use Exception;
18
19			class Certificate
20			{
21			/**
22			* File to decode.
23			*
24			* @var string
25			*/
26			protected $file;
27
28			/**
29			* Password to the decode the file.
30			*
31			* @var string
32			*/
33			protected $password;
34
35			/**
36			* @var string
37			*/
38			protected $strategy;
39
40			/**
41			* Create a new certificate instance.
42			*
43			* @param string $file
44			* @param string $password
45			* @param string $strategy
46			*/
47			public function __construct(string $file, string $password = null, string $strategy = null)
48			{
49			$this->file = new IO($file);
			0 ignored issues – show Documentation Bug introduced 2018-02-06 16:02 UTC by Report Bug Copy Issue Report It seems like `new \Kinedu\CfdiCertificate\IO($file)` of type `object<Kinedu\CfdiCertificate\IO>` is incompatible with the declared type `string` of property `$file`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
50			$this->password = $password;
51			$this->strategy = $strategy;
52			}
53
54			/**
55			* @return CerStrategy\|KeyStrategy\|null
56			*/
57			protected function getStrategy()
58			{
59			switch ($this->getFileExstensionName()) {
60			case 'cer':
61			$strategy = new CerStrategy(
62			$this->file->getOrginalRoute()
			0 ignored issues – show Bug introduced 2018-02-06 16:02 UTC by Report Bug Copy Issue Report The method `getOrginalRoute` cannot be called on `$this->file` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
63			);
64			break;
65
66			case 'key':
67			$strategy = new KeyStrategy(
68			$this->file->getOrginalRoute(),
			0 ignored issues – show Bug introduced 2018-02-06 16:02 UTC by Report Bug Copy Issue Report The method `getOrginalRoute` cannot be called on `$this->file` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
69			$this->password
70			);
71			break;
72			}
73
74			return $strategy;
			0 ignored issues – show Bug introduced 2018-02-06 16:02 UTC by Report Bug Copy Issue Report The variable `$strategy` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
75			}
76
77			/**
78			* @return string
79			*/
80			public function decode() : string
81			{
82			$strategy = $this->getStrategy();
83			$pem = $strategy->convertToPem();
84
85			return $pem;
86			}
87
88			/**
89			* @param string $directory
90			* @param string $filename
91			*
92			* @return integer\|bool
93			*/
94			public function save(string $directory, string $filename = null)
95			{
96			$filename = $filename ?? $this->file->getFileName();
			0 ignored issues – show Bug introduced 2018-02-15 21:55 UTC by Report Bug Copy Issue Report The method `getFileName` cannot be called on `$this->file` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
97			$extension = $this->getFileExstensionName();
98
99			$directory = rtrim($directory, '/').'/';
100			$directory = "{$directory}{$filename}.{$extension}.pem";
101
102			return file_put_contents($directory, $this->decode());
103			}
104
105			/**
106			* @param string $name
107			* @param array $arguments
108			*/
109			public function __call(string $name, array $arguments)
110			{
111			$strategy = $this->getStrategy();
112
113			if (method_exists($strategy, $name)) {
114			return $strategy->{$name}($arguments);
115			} else {
116			throw new Exception("This method doesn't exist");
117			}
118			}
119
120			/**
121			* @return string
122			*/
123			protected function getFileExstensionName()
124			{
125			return $this->strategy ?? $this->file->getFileExstensionName();
			0 ignored issues – show Bug introduced 2018-02-19 19:11 UTC by Report Bug Copy Issue Report The method `getFileExstensionName` cannot be called on `$this->file` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
126			}
127			}
128

Kinedu / cfdi-certificate

GitHub Access Token became invalid

Push — master ( 7bc96a...a2e938 )

Certificate::getFileExstensionName() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like