CerStrategy - Code Metrics - Inspection of "Add getNoCertificado method" - Kinedu/cfdi-certificate - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7a7b9b...3fa611 )

by Orlando

created 2018-02-13 19:14 UTC

CerStrategy A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
wmc	5
lcom	1
cbo	0
dl	0
loc	66
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	convertToPem()	11	1
A	getNoCertificado()	11	2
A	parseCertificate()	4	1

<?php

/*
 * This file is part of the cfdi-certificate project.
 *
 * (c) Kinedu
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Kinedu\CfdiCertificate\Strategies;

class CerStrategy
{
    /**
     * File to decode.
     *
     * @var string
     */
    protected $file;

    /**
     * Chunk length.
     *
     * @var integer
     */
    protected $chunklen = 64;

    /**
     * Create a new cer strategy instance.
     *
     * @param $file
     */
    public function __construct($file)
    {
        $this->file = file_get_contents($file);
    }

    /**
     * Convert .cer to .pem
     *
     * @return string
     */
    public function convertToPem() : string
    {
        $prefix = "-----BEGIN CERTIFICATE-----\n";
        $suffix = "-----END CERTIFICATE-----\n";

        $pem = base64_encode($this->file);
        $pem = chunk_split($pem, $this->chunklen, "\n") ;
        $pem = $prefix.$pem.$suffix;

        return $pem;
    }

    /**
     * @return string
     */
    public function getNoCertificado()
    {
        $data = $this->parseCertificate();
        $data = str_split($data['serialNumberHex'], 2);

        for ($i = 0; $i < sizeof($data); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            $serialNumber .= substr($data[$i], 1);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        }

        return $serialNumber;
    }

    /**
     * @return array
     */
    protected function parseCertificate()
    {
        return openssl_x509_parse($this->convertToPem());
    }
}


1			<?php
2
3			/*
4			* This file is part of the cfdi-certificate project.
5			*
6			* (c) Kinedu
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Kinedu\CfdiCertificate\Strategies;
13
14			class CerStrategy
15			{
16			/**
17			* File to decode.
18			*
19			* @var string
20			*/
21			protected $file;
22
23			/**
24			* Chunk length.
25			*
26			* @var integer
27			*/
28			protected $chunklen = 64;
29
30			/**
31			* Create a new cer strategy instance.
32			*
33			* @param $file
34			*/
35			public function __construct($file)
36			{
37			$this->file = file_get_contents($file);
38			}
39
40			/**
41			* Convert .cer to .pem
42			*
43			* @return string
44			*/
45			public function convertToPem() : string
46			{
47			$prefix = "-----BEGIN CERTIFICATE-----\n";
48			$suffix = "-----END CERTIFICATE-----\n";
49
50			$pem = base64_encode($this->file);
51			$pem = chunk_split($pem, $this->chunklen, "\n") ;
52			$pem = $prefix.$pem.$suffix;
53
54			return $pem;
55			}
56
57			/**
58			* @return string
59			*/
60			public function getNoCertificado()
61			{
62			$data = $this->parseCertificate();
63			$data = str_split($data['serialNumberHex'], 2);
64
65			for ($i = 0; $i < sizeof($data); $i++) {
			0 ignored issues – show Performance Best Practice introduced 2018-02-13 19:15 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `sizeof()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
66			$serialNumber .= substr($data[$i], 1);
			0 ignored issues – show Bug introduced 2018-02-13 19:15 UTC by Report Bug Copy Issue Report The variable `$serialNumber` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
67			}
68
69			return $serialNumber;
70			}
71
72			/**
73			* @return array
74			*/
75			protected function parseCertificate()
76			{
77			return openssl_x509_parse($this->convertToPem());
78			}
79			}
80

Kinedu / cfdi-certificate

GitHub Access Token became invalid

Push — master ( 7a7b9b...3fa611 )

CerStrategy A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like