Certificate::getStrategy() - Code Metrics - Inspection of "Add save method" - Kinedu/cfdi-certificate - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d37384...36d9ed )

by Orlando

created 2018-02-07 16:50 UTC

Certificate::getStrategy() A

↳ Parent: Certificate

Complexity

Conditions	3
Paths	3

Size

Total Lines	19
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	12
nc	3
nop	0

<?php

/*
 * This file is part of the cfdi-certificate project.
 *
 * (c) Kinedu
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Kinedu\CfdiCertificate;

use Kinedu\CfdiCertificate\Strategies\CerStrategy;
use Kinedu\CfdiCertificate\Strategies\KeyStrategy;
use Kinedu\CfdiCertificate\IO;

class Certificate
{
    /**
     * @var string
     */
    protected $file;

    /**
     * @var string
     */
    protected $password;

    /**
     * Create a new certificate instance.
     *
     * @param string $file
     * @param string $password
     */
    public function __construct(string $file, string $password = null)
    {
        $this->file = new IO($file);

        $this->password = $password;
    }

    /**
     * @return CerStrategy|KeyStrategy|null
     */
    protected function getStrategy()
    {
        switch ($this->file->getFileExstensionName()) {

            case 'cer':
                $strategy = new CerStrategy(
                    $this->file->getOrginalRoute()

                );
            break;

            case 'key':
                $strategy = new KeyStrategy(
                    $this->file->getOrginalRoute(),

                    $this->password
                );
            break;
        }

        return $strategy;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    /**
     * @return string
     */
    public function decode() : string
    {
        $strategy = $this->getStrategy();
        $pem = $strategy->convertToPem();

        return $pem;
    }

    /**
     * @param string $filename
     *
     * @return
     */
    public function save(string $filename)
    {
        return file_put_contents($filename, $this->decode());
    }
}


GitHub Access Token became invalid

Push — master ( d37384...36d9ed )

Certificate::getStrategy() A

Complexity

Size

Duplication

Importance

Available Fixes

1			<?php
2
3			/*
4			* This file is part of the cfdi-certificate project.
5			*
6			* (c) Kinedu
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Kinedu\CfdiCertificate;
13
14			use Kinedu\CfdiCertificate\Strategies\CerStrategy;
15			use Kinedu\CfdiCertificate\Strategies\KeyStrategy;
16			use Kinedu\CfdiCertificate\IO;
17
18			class Certificate
19			{
20			/**
21			* @var string
22			*/
23			protected $file;
24
25			/**
26			* @var string
27			*/
28			protected $password;
29
30			/**
31			* Create a new certificate instance.
32			*
33			* @param string $file
34			* @param string $password
35			*/
36			public function __construct(string $file, string $password = null)
37			{
38			$this->file = new IO($file);
			0 ignored issues – show Documentation Bug introduced 2018-02-06 16:02 UTC by Report Bug Copy Issue Report It seems like `new \Kinedu\CfdiCertificate\IO($file)` of type `object<Kinedu\CfdiCertificate\IO>` is incompatible with the declared type `string` of property `$file`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
39			$this->password = $password;
40			}
41
42			/**
43			* @return CerStrategy\|KeyStrategy\|null
44			*/
45			protected function getStrategy()
46			{
47			switch ($this->file->getFileExstensionName()) {
			0 ignored issues – show Bug introduced 2018-02-06 16:02 UTC by Report Bug Copy Issue Report The method `getFileExstensionName` cannot be called on `$this->file` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
48			case 'cer':
49			$strategy = new CerStrategy(
50			$this->file->getOrginalRoute()
			0 ignored issues – show Bug introduced 2018-02-06 16:02 UTC by Report Bug Copy Issue Report The method `getOrginalRoute` cannot be called on `$this->file` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
51			);
52			break;
53
54			case 'key':
55			$strategy = new KeyStrategy(
56			$this->file->getOrginalRoute(),
			0 ignored issues – show Bug introduced 2018-02-06 16:02 UTC by Report Bug Copy Issue Report The method `getOrginalRoute` cannot be called on `$this->file` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
57			$this->password
58			);
59			break;
60			}
61
62			return $strategy;
			0 ignored issues – show Bug introduced 2018-02-06 16:02 UTC by Report Bug Copy Issue Report The variable `$strategy` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
63			}
64
65			/**
66			* @return string
67			*/
68			public function decode() : string
69			{
70			$strategy = $this->getStrategy();
71			$pem = $strategy->convertToPem();
72
73			return $pem;
74			}
75
76			/**
77			* @param string $filename
78			*
79			* @return
80			*/
81			public function save(string $filename)
82			{
83			return file_put_contents($filename, $this->decode());
84			}
85			}
86

Kinedu / cfdi-certificate

GitHub Access Token became invalid

Push — master ( d37384...36d9ed )

Certificate::getStrategy() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like