CerStrategy::dateFormat() - Code Metrics - Inspection of "Add getExpirationDate method" - Kinedu/cfdi-certificate - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 93e9ae...b218d4 )

by Orlando

created 2018-02-13 22:28 UTC

CerStrategy::dateFormat() A

↳ Parent: CerStrategy

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1

<?php

/*
 * This file is part of the cfdi-certificate project.
 *
 * (c) Kinedu
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Kinedu\CfdiCertificate\Strategies;

class CerStrategy
{
    /**
     * File to decode.
     *
     * @var string
     */
    protected $file;

    /**
     * Chunk length.
     *
     * @var integer
     */
    protected $chunklen = 64;

    /**
     * Create a new cer strategy instance.
     *
     * @param $file
     */
    public function __construct($file)
    {
        $this->file = file_get_contents($file);
    }

    /**
     * Convert .cer to .pem
     *
     * @return string
     */
    public function convertToPem() : string
    {
        $prefix = "-----BEGIN CERTIFICATE-----\n";
        $suffix = "-----END CERTIFICATE-----\n";

        $pem = base64_encode($this->file);
        $pem = chunk_split($pem, $this->chunklen, "\n") ;
        $pem = $prefix.$pem.$suffix;

        return $pem;
    }

    /**
     * @return string
     */
    public function getNoCertificado()
    {
        $data = $this->parseCertificate();
        $data = str_split($data['serialNumberHex'], 2);

        $serialNumber = null;

        for ($i = 0; $i < sizeof($data); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            $serialNumber .= substr($data[$i], 1);
        }

        return $serialNumber;
    }

    /**
     * @return string
     */
    public function getExpirationDate()
    {
        $data = $this->parseCertificate();

        return $this->dateFormat($data['validTo_time_t']);
    }

    /**
     * @return array
     */
    protected function parseCertificate()
    {
        return openssl_x509_parse($this->convertToPem());
    }

    /**
     * @param string $date
     */
    protected function dateFormat(string $date)
    {
        return date('Y-m-d H:i:s', $date);
    }
}


1			<?php
2
3			/*
4			* This file is part of the cfdi-certificate project.
5			*
6			* (c) Kinedu
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Kinedu\CfdiCertificate\Strategies;
13
14			class CerStrategy
15			{
16			/**
17			* File to decode.
18			*
19			* @var string
20			*/
21			protected $file;
22
23			/**
24			* Chunk length.
25			*
26			* @var integer
27			*/
28			protected $chunklen = 64;
29
30			/**
31			* Create a new cer strategy instance.
32			*
33			* @param $file
34			*/
35			public function __construct($file)
36			{
37			$this->file = file_get_contents($file);
38			}
39
40			/**
41			* Convert .cer to .pem
42			*
43			* @return string
44			*/
45			public function convertToPem() : string
46			{
47			$prefix = "-----BEGIN CERTIFICATE-----\n";
48			$suffix = "-----END CERTIFICATE-----\n";
49
50			$pem = base64_encode($this->file);
51			$pem = chunk_split($pem, $this->chunklen, "\n") ;
52			$pem = $prefix.$pem.$suffix;
53
54			return $pem;
55			}
56
57			/**
58			* @return string
59			*/
60			public function getNoCertificado()
61			{
62			$data = $this->parseCertificate();
63			$data = str_split($data['serialNumberHex'], 2);
64
65			$serialNumber = null;
66
67			for ($i = 0; $i < sizeof($data); $i++) {
			0 ignored issues – show Performance Best Practice introduced 2018-02-13 19:15 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `sizeof()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
68			$serialNumber .= substr($data[$i], 1);
69			}
70
71			return $serialNumber;
72			}
73
74			/**
75			* @return string
76			*/
77			public function getExpirationDate()
78			{
79			$data = $this->parseCertificate();
80
81			return $this->dateFormat($data['validTo_time_t']);
82			}
83
84			/**
85			* @return array
86			*/
87			protected function parseCertificate()
88			{
89			return openssl_x509_parse($this->convertToPem());
90			}
91
92			/**
93			* @param string $date
94			*/
95			protected function dateFormat(string $date)
96			{
97			return date('Y-m-d H:i:s', $date);
98			}
99			}
100

Kinedu / cfdi-certificate

GitHub Access Token became invalid

Push — master ( 93e9ae...b218d4 )

CerStrategy::dateFormat() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like