CerStrategy::convertToPem() - Code Metrics - Inspection of "Rename convertToPem method to decode" - Kinedu/cfdi-certificate - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6c0a65...c0dc95 )

by Orlando

created 2019-07-29 15:57 UTC

CerStrategy::convertToPem() A

↳ Parent: CerStrategy

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	11
rs	9.9
c	0
b	0
f	0

<?php

/*
 * This file is part of the cfdi-certificate project.
 *
 * (c) Kinedu
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Kinedu\CfdiCertificate\Strategies;

class CerStrategy
{
    /**
     * File to decode.
     *
     * @var string
     */
    protected $file;

    /**
     * Chunk length.
     *
     * @var integer
     */
    protected $chunkLength = 64;

    /**
     * Create a new cer strategy instance.
     *
     * @param string $file
     */
    public function __construct(string $file)
    {
        $this->file = file_get_contents($file);
    }

    /**
     * Convert .cer to .pem
     *
     * @return string
     */
    public function decode(): string
    {
        $prefix = "-----BEGIN CERTIFICATE-----\n";
        $suffix = "-----END CERTIFICATE-----\n";

        $pem = base64_encode($this->file);
        $pem = chunk_split($pem, $this->chunkLength, "\n") ;
        $pem = $prefix.$pem.$suffix;

        return $pem;
    }

    public function getCertificateNumber(): string
    {
        $data = $this->parseCertificate();
        $data = str_split($data['serialNumberHex'], 2);

        $serialNumber = null;

        for ($i = 0; $i < sizeof($data); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            $serialNumber .= substr($data[$i], 1);
        }

        return $serialNumber;
    }

    public function getExpirationDate(): string
    {
        $data = $this->parseCertificate();

        return $this->dateFormat($data['validTo_time_t']);
    }

    public function getInitialDate(): string
    {
        $data = $this->parseCertificate();

        return $this->dateFormat($data['validFrom_time_t']);
    }

    protected function parseCertificate(): array
    {
        return openssl_x509_parse($this->decode());
    }

    protected function dateFormat(string $date): string
    {
        return date('Y-m-d H:i:s', $date);
    }
}


1			<?php
2
3			/*
4			* This file is part of the cfdi-certificate project.
5			*
6			* (c) Kinedu
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Kinedu\CfdiCertificate\Strategies;
13
14			class CerStrategy
15			{
16			/**
17			* File to decode.
18			*
19			* @var string
20			*/
21			protected $file;
22
23			/**
24			* Chunk length.
25			*
26			* @var integer
27			*/
28			protected $chunkLength = 64;
29
30			/**
31			* Create a new cer strategy instance.
32			*
33			* @param string $file
34			*/
35			public function __construct(string $file)
36			{
37			$this->file = file_get_contents($file);
38			}
39
40			/**
41			* Convert .cer to .pem
42			*
43			* @return string
44			*/
45			public function decode(): string
46			{
47			$prefix = "-----BEGIN CERTIFICATE-----\n";
48			$suffix = "-----END CERTIFICATE-----\n";
49
50			$pem = base64_encode($this->file);
51			$pem = chunk_split($pem, $this->chunkLength, "\n") ;
52			$pem = $prefix.$pem.$suffix;
53
54			return $pem;
55			}
56
57			public function getCertificateNumber(): string
58			{
59			$data = $this->parseCertificate();
60			$data = str_split($data['serialNumberHex'], 2);
61
62			$serialNumber = null;
63
64			for ($i = 0; $i < sizeof($data); $i++) {
			0 ignored issues – show Performance Best Practice introduced 2018-02-13 19:15 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `sizeof()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
65			$serialNumber .= substr($data[$i], 1);
66			}
67
68			return $serialNumber;
69			}
70
71			public function getExpirationDate(): string
72			{
73			$data = $this->parseCertificate();
74
75			return $this->dateFormat($data['validTo_time_t']);
76			}
77
78			public function getInitialDate(): string
79			{
80			$data = $this->parseCertificate();
81
82			return $this->dateFormat($data['validFrom_time_t']);
83			}
84
85			protected function parseCertificate(): array
86			{
87			return openssl_x509_parse($this->decode());
88			}
89
90			protected function dateFormat(string $date): string
91			{
92			return date('Y-m-d H:i:s', $date);
93			}
94			}
95

Kinedu / cfdi-certificate

GitHub Access Token became invalid

Push — master ( 6c0a65...c0dc95 )

CerStrategy::convertToPem() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like