Kilix / php-abac

src/Abac.php

<?php

namespace PhpAbac;

use PhpAbac\Manager\AttributeManager;
use PhpAbac\Manager\PolicyRuleManager;
use PhpAbac\Manager\ConfigurationManager;
use PhpAbac\Manager\CacheManager;
use PhpAbac\Manager\ComparisonManager;

use Symfony\Component\Config\FileLocator;

use PhpAbac\Model\PolicyRuleAttribute;

class Abac {
	/** @var \PhpAbac\Manager\ConfigurationManager * */
	private $configuration;
	/** @var \PhpAbac\Manager\PolicyRuleManager * */
	private $policyRuleManager;
	/** @var \PhpAbac\Manager\AttributeManager * */
	private $attributeManager;
	/** @var \PhpAbac\Manager\CacheManager * */
	private $cacheManager;
	/** @var \PhpAbac\Manager\ComparisonManager * */
	private $comparisonManager;
	
	/**
	 * @param array  $configPaths
	 * @param array  $cacheOptions     Option for cache
	 * @param string $configPaths_root The origin folder to find $configPaths
	 * @param array  $options
	 */
	public function __construct( $configPaths, $cacheOptions = [], $configPaths_root = null, $options = [] ) {

Expected 0 spaces between opening bracket and argument "$configPaths"; 1 found

Expected 0 spaces between argument "$options" and closing bracket; 1 found

		$this->configure( $configPaths, $configPaths_root );
		$this->attributeManager = new AttributeManager( $this->configuration->getAttributes(), $options );
		$this->policyRuleManager = new PolicyRuleManager( $this->attributeManager, $this->configuration->getRules() );
		$this->cacheManager      = new CacheManager( $cacheOptions );
		$this->comparisonManager = new ComparisonManager( $this->attributeManager );
	}
	
	/**
	 * @param array  $configPaths
	 * @param string $configPaths_root The origin folder to find $configPaths
	 */
	public function configure( $configPaths, $configPaths_root = null ) {

Expected 0 spaces between opening bracket and argument "$configPaths"; 1 found

Expected 0 spaces between argument "$configPaths_root" and closing bracket; 1 found

//		foreach ( $configPaths as &$configPath ) {
//			$configPath = $configPaths_root . $configPath;
//		}
		$locator             = new FileLocator( $configPaths_root );
		$this->configuration = new ConfigurationManager( $locator );
		$this->configuration->setConfigPathRoot( $configPaths_root );
		$this->configuration->parseConfigurationFile( $configPaths );
	}
	
	/**
	 * Return true if both user and object respects all the rules conditions
	 * If the objectId is null, policy rules about its attributes will be ignored
	 * In case of mismatch between attributes and expected values,
	 * an array with the concerned attributes slugs will be returned.
	 *
	 * Available options are :
	 * * dynamic_attributes: array
	 * * cache_result: boolean
	 * * cache_ttl: integer
	 * * cache_driver: string
	 *
	 * Available cache drivers are :
	 * * memory
	 *
	 * @param string $ruleName
	 * @param object $user
	 * @param object $resource
	 * @param array  $options
	 *
	 * @return boolean|array
	 */
	public function enforce( $ruleName, $user, $resource = null, $options = [] ) {

Expected 0 spaces between opening bracket and argument "$ruleName"; 1 found

Expected 0 spaces between argument "$options" and closing bracket; 1 found

		// If there is dynamic attributes, we pass them to the comparison manager
		// When a comparison will be performed, the passed values will be retrieved and used
		if ( isset( $options[ 'dynamic_attributes' ] ) ) {
			$this->comparisonManager->setDynamicAttributes( $options[ 'dynamic_attributes' ] );
		}
		// Retrieve cache value for the current rule and values if cache item is valid
		if ( ( $cacheResult = isset( $options[ 'cache_result' ] ) && $options[ 'cache_result' ] === true ) === true ) {

Consider adding parentheses for clarity. Current Interpretation: $cacheResult = (isset($options['cache_result']) && $options['cache_result'] === true), Probably Intended Meaning: ($cacheResult = isset($options['cache_result'])) && $options['cache_result'] === true

			$cacheItem = $this->cacheManager->getItem( "$ruleName-{$user->getId()}-" . ( ( $resource !== null ) ? $resource->getId() : '' ), ( isset( $options[ 'cache_driver' ] ) ) ? $options[ 'cache_driver' ] : null, ( isset( $options[ 'cache_ttl' ] ) ) ? $options[ 'cache_ttl' ] : null );
			// We check if the cache value s valid before returning it
			if ( ( $cacheValue = $cacheItem->get() ) !== null ) {

Expected 0 spaces before closing bracket; 1 found

				return $cacheValue;
			}
		}
		$policyRule_a = $this->policyRuleManager->getRule( $ruleName, $user, $resource );

It seems like $resource defined by parameter $resource on line 77 can also be of type null; however, PhpAbac\Manager\PolicyRuleManager::getRule() does only seem to accept object, maybe add an additional type check?

		
		foreach ( $policyRule_a as $policyRule ) {

Space found after opening bracket of FOREACH loop

Space found before closing bracket of FOREACH loop

Expected 0 spaces before closing bracket; 1 found

			// For each policy rule attribute, we retrieve the attribute value and proceed configured extra data
			foreach ( $policyRule->getPolicyRuleAttributes() as $pra ) {

Space found after opening bracket of FOREACH loop

Space found before closing bracket of FOREACH loop

Expected 0 spaces before closing bracket; 1 found

				/** @var PolicyRuleAttribute $pra */
				$attribute = $pra->getAttribute();
				
				$getter_params = $this->prepareGetterParams($pra->getGetterParams(), $user, $resource);
//				var_dump($pra->getGetterParams());
//				var_dump($getter_params);
				$attribute->setValue( $this->attributeManager->retrieveAttribute( $attribute, $user, $resource, $getter_params ) );
				if ( count( $pra->getExtraData() ) > 0 ) {
					$this->processExtraData( $pra, $user, $resource );

It seems like $resource defined by parameter $resource on line 77 can also be of type null; however, PhpAbac\Abac::processExtraData() does only seem to accept object, maybe add an additional type check?

				}
				$this->comparisonManager->compare( $pra );
			}
			// The given result could be an array of rejected attributes or true
			// True means that the rule is correctly enforced for the given user and resource
			$result = $this->comparisonManager->getResult();
			if ( true === $result ) {

Expected 0 spaces before closing bracket; 1 found

				break;
			}
		}
		if ( $cacheResult ) {

Expected 0 spaces before closing bracket; 1 found

			$cacheItem->set( $result );

The variable $cacheItem does not seem to be defined for all execution paths leading up to this point.

The variable $result does not seem to be defined for all execution paths leading up to this point.

			$this->cacheManager->save( $cacheItem );
		}
		
		return $result;
	}
	
	/**
	 * Function to prepare Getter Params when getter require parameters ( this parameters must be specified in configuration file)
	 *
	 * @param $getter_params
	 * @param $user
	 * @param $resource
	 *
	 * @return array
	 */
	private function prepareGetterParams($getter_params, $user, $resource) {
		if (empty($getter_params)) return [];

It is generally a best practice to always use braces with control structures.

		$values = [];
		foreach($getter_params as $getter_name=>$params) {

Expected 1 space after FOREACH keyword; 0 found

Expected 1 space before "=>"; 0 found

Expected 1 space after "=>"; 0 found

			foreach($params as $param) {

Expected 1 space after FOREACH keyword; 0 found

				if ( '@' !== $param[ 'param_name' ][ 0 ] ) {

Expected 0 spaces before closing bracket; 1 found

					$values[$getter_name][] = $param[ 'param_value' ];
				}
				else {
					$values[$getter_name][] = $this->attributeManager->retrieveAttribute( $this->attributeManager->getAttribute( $param[ 'param_value' ] ) , $user, $resource );

Space found before comma in function call

				}
			}
		}
		return $values;
	}
	
	/**
	 * @param \PhpAbac\Model\PolicyRuleAttribute $pra
	 * @param object                             $user
	 * @param object                             $resource
	 */
	public function processExtraData( PolicyRuleAttribute $pra, $user, $resource ) {

Expected 0 spaces between opening bracket and type hint "PolicyRuleAttribute"; 1 found

Expected 0 spaces between argument "$resource" and closing bracket; 1 found

		foreach ( $pra->getExtraData() as $key => $data ) {

Space found after opening bracket of FOREACH loop

Space found before closing bracket of FOREACH loop

Expected 0 spaces before closing bracket; 1 found

			switch ( $key ) {

Expected 0 spaces before closing bracket; 1 found

				case 'with':
					// This data has to be removed for it will be stored elsewhere
					// in the policy rule attribute
					$pra->removeExtraData( 'with' );
					// The "with" extra data is an array of attributes, which are objects
					// Once we process it as policy rule attributes, we set it as the main policy rule attribute value
					$subPolicyRuleAttributes = [];
					$extraData               = [];

$extraData is not used, you could remove the assignment.

					
					foreach ( $this->policyRuleManager->processRuleAttributes( $data, $user, $resource ) as $subPolicyRuleAttribute ) {

Space found after opening bracket of FOREACH loop

Space found before closing bracket of FOREACH loop

						$subPolicyRuleAttributes[] = $subPolicyRuleAttribute;
					}
					$pra->setValue( $subPolicyRuleAttributes );
					// This data can be used in complex comparisons
					$pra->addExtraData( 'attribute', $pra->getAttribute() );
					$pra->addExtraData( 'user', $user );

$user is of type object, but the function expects a string.

					$pra->addExtraData( 'resource', $resource );

$resource is of type object, but the function expects a string.

					break;
			}
		}
	}
}