PolicyRuleManager::getRuleByName() - Code Metrics - Inspection of "Release v2.0.0" - Kilix/php-abac - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d1c731...ca9b69 )

by Axel

created 2016-05-26 14:49 UTC

PolicyRuleManager::getRuleByName() A

↳ Parent: PolicyRuleManager

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2.0625

Importance

Changes	3
Bugs	1	Features	2

Metric	Value
c	3
b	1
f	2
dl	0
loc	8
ccs	3
cts	4
cp	0.75
rs	9.4285
cc	2
eloc	4
nc	2
nop	1
crap	2.0625

<?php

namespace PhpAbac\Manager;

use PhpAbac\Abac;
use PhpAbac\Model\PolicyRule;
use PhpAbac\Model\PolicyRuleAttribute;

class PolicyRuleManager
{
    /** @var \PhpAbac\Manager\AttributeManager **/
    private $attributeManager;
    /** @var array **/
    private $rules;

    /**
     * @param \PhpAbac\Manager\AttributeManager $attributeManager
     * @param array $rules
     */
    public function __construct(AttributeManager $attributeManager, $rules)
    {
        $this->attributeManager = $attributeManager;
        $this->rules = $rules;
    }

    /**
     * @param string $ruleName
     *
     * @return PolicyRule
     *
     * @throws \InvalidArgumentException
     */
    public function getRule($ruleName)
    {
        if(!isset($this->rules[$ruleName])) {

            throw new \InvalidArgumentException('The given rule "' . $ruleName . '" is not configured');
        }
        $rule =
            (new PolicyRule())
            ->setName($ruleName)
        ;
        $this->processRuleAttributes($rule);
        return $rule;
    }
    
    /**
     * @param PolicyRule $rule
     */
    private function processRuleAttributes(PolicyRule $rule) {
        foreach($this->rules[$rule->getName()]['attributes'] as $attributeName => $attribute) {

            $rule->addPolicyRuleAttribute(
                (new PolicyRuleAttribute())
                ->setAttribute($this->attributeManager->getAttribute($attributeName))
                ->setComparison($attribute['comparison'])
                ->setComparisonType($attribute['comparison_type'])
                ->setValue($attribute['value'])
            );
        }
    }
}


1		<?php
2
3		namespace PhpAbac\Manager;
4
5		use PhpAbac\Abac;
6		use PhpAbac\Model\PolicyRule;
7		use PhpAbac\Model\PolicyRuleAttribute;
8
9		class PolicyRuleManager
10		{
11		/ @var \PhpAbac\Manager\AttributeManager /
12		private $attributeManager;
13		/ @var array /
14		private $rules;
15
16		/**
17		* @param \PhpAbac\Manager\AttributeManager $attributeManager
18		* @param array $rules
19		*/
20	2	public function __construct(AttributeManager $attributeManager, $rules)
21		{
22	2	$this->attributeManager = $attributeManager;
23	2	$this->rules = $rules;
24	2	}
25
26		/**
27		* @param string $ruleName
28		*
29		* @return PolicyRule
30		*
31		* @throws \InvalidArgumentException
32		*/
33	2	public function getRule($ruleName)
34		{
35	2	if(!isset($this->rules[$ruleName])) {
		0 ignored issues – show Coding Style introduced 2016-05-26 14:52 UTC by Report Bug Copy Issue Report Expected 1 space after IF keyword; 0 found Loading history...
36		throw new \InvalidArgumentException('The given rule "' . $ruleName . '" is not configured');
37		}
38		$rule =
39	2	(new PolicyRule())
40	2	->setName($ruleName)
41	2	;
42	2	$this->processRuleAttributes($rule);
43	2	return $rule;
44		}
45
46		/**
47		* @param PolicyRule $rule
48		*/
49	2	private function processRuleAttributes(PolicyRule $rule) {
50	2	foreach($this->rules[$rule->getName()]['attributes'] as $attributeName => $attribute) {
		0 ignored issues – show Coding Style introduced 2016-05-26 14:52 UTC by Report Bug Copy Issue Report Expected 1 space after FOREACH keyword; 0 found Loading history...
51	2	$rule->addPolicyRuleAttribute(
52	2	(new PolicyRuleAttribute())
53	2	->setAttribute($this->attributeManager->getAttribute($attributeName))
54	2	->setComparison($attribute['comparison'])
55	2	->setComparisonType($attribute['comparison_type'])
56	2	->setValue($attribute['value'])
57	2	);
58	2	}
59	2	}
60		}
61

Kilix / php-abac

GitHub Access Token became invalid

Push — master ( d1c731...ca9b69 )

PolicyRuleManager::getRuleByName() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like