PhpAbac\Abac

Complexity

Total Complexity

15

Size/Duplication

Total Lines	91
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	7

Test Coverage

Coverage

74.42%

Importance

Changes	14
Bugs	1	Features	5

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	configure()	0	5	1
C	enforce()	0	38	13

<?php

namespace PhpAbac;

use PhpAbac\Manager\AttributeManager;
use PhpAbac\Manager\PolicyRuleManager;
use PhpAbac\Manager\ConfigurationManager;
use PhpAbac\Manager\CacheManager;

use Symfony\Component\Config\FileLocator;

class Abac
{
    /** @var \PhpAbac\Manager\ConfigurationManager **/
    private $configuration;
    /** @var \PhpAbac\Manager\PolicyRuleManager **/
    private $policyRuleManager;
    /** @var \PhpAbac\Manager\AttributeManager **/
    private $attributeManager;
    /** @var \PhpAbac\Manager\CacheManager **/
    private $cacheManager;

    /**
     * @param array $configPaths
     */
    public function __construct($configPaths)
    {
        $this->configure($configPaths);
        $this->attributeManager = new AttributeManager($this->configuration->getAttributes());
        $this->policyRuleManager = new PolicyRuleManager($this->attributeManager, $this->configuration->getRules());
        $this->cacheManager = new CacheManager();
    }
    
    /**
     * @param array $configPaths
     */
    public function configure($configPaths) {
        $locator = new FileLocator($configPaths);
        $this->configuration = new ConfigurationManager($locator);
        $this->configuration->parseConfigurationFile($configPaths);
    }

    /**
     * Return true if both user and object respects all the rules conditions
     * If the objectId is null, policy rules about its attributes will be ignored
     * In case of mismatch between attributes and expected values,
     * an array with the concerned attributes slugs will be returned.
     * 
     * Available options are :
     * * dynamic_attributes: array
     * * cache_result: boolean
     * * cache_ttl: integer
     * * cache_driver: string
     * 
     * Available cache drivers are :
     * * memory
     * 
     * @param string $ruleName
     * @param object $user
     * @param object $object
     * @param array $options
     * @return boolean|array
     */
    public function enforce($ruleName, $user, $object = null, $options = []) {
        // Retrieve cache value for the current rule and values if cache item is valid
        if(($cacheResult = isset($options['cache_result']) && $options['cache_result'] === true) === true) {

Consider adding parentheses for clarity. Current Interpretation: $cacheResult = (isset($options['cache_result']) && $options['cache_result'] === true), Probably Intended Meaning: ($cacheResult = isset($options['cache_result'])) && $options['cache_result'] === true

Expected 1 space after IF keyword; 0 found

            $cacheItem = $this->cacheManager->getItem(
                "$ruleName-{$user->getId()}-" . (($object !== null) ? $object->getId() : ''),
                (isset($options['cache_driver'])) ? $options['cache_driver'] : null,
                (isset($options['cache_ttl'])) ? $options['cache_ttl'] : null
            );
            // We check if the cache value s valid before returning it
            if(($cacheValue = $cacheItem->get()) !== null) {

Expected 1 space after IF keyword; 0 found

                return $cacheValue;
            }
        }
        $policyRule = $this->policyRuleManager->getRule($ruleName);
        $rejectedAttributes = [];

        foreach ($policyRule->getPolicyRuleAttributes() as $pra) {
            $attribute = $pra->getAttribute();
            $attribute->setValue($this->attributeManager->retrieveAttribute($attribute, $user, $object));
            $comparisonClass = 'PhpAbac\\Comparison\\'.ucfirst($pra->getComparisonType()).'Comparison';
            $comparison = new $comparisonClass();
            $dynamicAttributes = (isset($options['dynamic_attributes'])) ? $options['dynamic_attributes'] : [];
            $value =
                ($pra->getValue() === 'dynamic')
                ? $this->attributeManager->getDynamicAttribute($attribute->getSlug(), $dynamicAttributes)
                : $pra->getValue()
            ;
            if ($comparison->{$pra->getComparison()}($value, $attribute->getValue()) !== true) {
                $rejectedAttributes[] = $attribute->getSlug();
            }
        }
        $result = (count($rejectedAttributes) === 0) ? : $rejectedAttributes;
        if($cacheResult) {

Expected 1 space after IF keyword; 0 found

            $cacheItem->set($result);

The variable $cacheItem does not seem to be defined for all execution paths leading up to this point.

            $this->cacheManager->save($cacheItem);
        }
        return $result;
    }
}