PhpAbac\Manager\PolicyRuleManager

Complexity

Total Complexity

12

Size/Duplication

Total Lines	82
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

96.67%

Importance

Changes	2
Bugs	1	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getRule()	0	15	3
B	processRuleAttributes()	0	20	5
A	processRuleAttributeComparisonType()	0	6	3

<?php

namespace PhpAbac\Manager;

use PhpAbac\Model\PolicyRule;
use PhpAbac\Model\PolicyRuleAttribute;

class PolicyRuleManager
{
    /** @var \PhpAbac\Manager\AttributeManager **/
    private $attributeManager;
    /** @var array **/
    private $rules;

    /**
     * @param \PhpAbac\Manager\AttributeManager $attributeManager
     * @param array $rules
     */
    public function __construct(AttributeManager $attributeManager, $rules)
    {
        $this->attributeManager = $attributeManager;
        $this->rules = $rules;
    }

    /**
     * @param string $ruleName
     * @param object $user
     * @param object $resource
     * @return PolicyRule
     * @throws \InvalidArgumentException
     */
    public function getRule($ruleName, $user, $resource)
    {
        if(!isset($this->rules[$ruleName])) {

Expected 1 space after IF keyword; 0 found

            throw new \InvalidArgumentException('The given rule "' . $ruleName . '" is not configured');
        }
        $rule =
            (new PolicyRule())
            ->setName($ruleName)
        ;
        // For each policy rule attribute, the data is formatted
        foreach($this->processRuleAttributes($this->rules[$ruleName]['attributes'], $user, $resource) as $pra) {

Expected 1 space after FOREACH keyword; 0 found

            $rule->addPolicyRuleAttribute($pra);
        }
        return $rule;
    }

    /**
     * This method is meant to convert attribute data from array to formatted policy rule attribute
     *
     * @param array $attributes
     * @param object $user
     * @param object $resource
     */
    public function processRuleAttributes($attributes, $user, $resource) {
        foreach($attributes as $attributeName => $attribute) {

Expected 1 space after FOREACH keyword; 0 found

            $pra = (new PolicyRuleAttribute())
                ->setAttribute($this->attributeManager->getAttribute($attributeName))
                ->setComparison($attribute['comparison'])
                ->setComparisonType($attribute['comparison_type'])
                ->setValue((isset($attribute['value'])) ? $attribute['value'] : null)
            ;
            $this->processRuleAttributeComparisonType($pra, $user, $resource);
            // In the case the user configured more keys than the basic ones
            // it will be stored as extra data
            foreach($attribute as $key => $value) {

Expected 1 space after FOREACH keyword; 0 found

                if(!in_array($key, ['comparison', 'comparison_type', 'value'])) {

Expected 1 space after IF keyword; 0 found

                    $pra->addExtraData($key, $value);
                }
            }
            // This generator avoid useless memory consumption instead of returning a whole array
            yield $pra;
        }
    }

    /**
     * This method is meant to set appropriated extra data to $pra depending on comparison type
     *
     * @param PolicyRuleAttribute $pra
     * @param object $user
     * @param object $resource
     */
    public function processRuleAttributeComparisonType(PolicyRuleAttribute $pra, $user, $resource) {
        switch($pra->getComparisonType()) {

Expected 1 space after SWITCH keyword; 0 found

            case 'user': $pra->setExtraData(['user' => $user]); break;

The case body in a switch statement must start on the line following the statement.

Terminating statement must be on a line by itself

It is generally recommended to place each PHP statement on a line by itself.

            case 'object': $pra->setExtraData(['resource' => $resource]); break;

The case body in a switch statement must start on the line following the statement.

Terminating statement must be on a line by itself

It is generally recommended to place each PHP statement on a line by itself.

        }
    }
}