Kilix / php-abac

src/Cache/Pool/MemoryCacheItemPool.php

Spacing +8 added lines, -8 removed lines

@@ -16,10 +16,10 @@ 
      * {@inheritdoc}
      */
     public function deleteItem($key) {
-        if(isset($this->items[$key])) {
+        if (isset($this->items[$key])) {
             unset($this->items[$key]);
         }
-        if(isset($this->deferredItems[$key])) {
+        if (isset($this->deferredItems[$key])) {
             unset($this->deferredItems[$key]);
         }
         return true;
@@ -29,8 +29,8 @@ 
      * {@inheritdoc}
      */
     public function deleteItems(array $keys) {
-        foreach($keys as $key) {
-            if(!$this->deleteItem($key)) {
+        foreach ($keys as $key) {
+            if (!$this->deleteItem($key)) {
                 return false;
             }
         }
@@ -59,7 +59,7 @@ 
      * {@inheritdoc}
      */
     public function commit() {
-        foreach($this->deferredItems as $key => $item) {
+        foreach ($this->deferredItems as $key => $item) {
             $this->items[$key] = $item;
             unset($this->deferredItems[$key]);
         }
@@ -77,7 +77,7 @@ 
      * {@inheritdoc}
      */
     public function getItem($key) {
-        if(!$this->hasItem($key)) {
+        if (!$this->hasItem($key)) {
             return new MemoryCacheItem($key);
         }
         return $this->items[$key];
@@ -88,8 +88,8 @@ 
      */
     public function getItems(array $keys = array()) {
         $items = [];
-        foreach($keys as $key) {
-            if($this->hasItem($key)) {
+        foreach ($keys as $key) {
+            if ($this->hasItem($key)) {
                 $items[$key] = $this->getItem($key);
             }
         }

src/Cache/Item/MemoryCacheItem.php

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
      * {@inheritdoc}
      */
     public function get() {
-        if(!$this->isHit()) {
+        if (!$this->isHit()) {
             throw new ExpiredCacheException('Cache item is expired');
         }
         return $this->value;

src/Model/PolicyRuleAttribute.php

Spacing +1 added lines, -1 removed lines

@@ -121,7 +121,7 @@
      * @return \PhpAbac\Model\PolicyRuleAttribute
      */
     public function removeExtraData($key) {
-        if(isset($this->extraData[$key])) {
+        if (isset($this->extraData[$key])) {
             unset($this->extraData[$key]);
         }
         return $this;

src/Manager/ComparisonManager.php

Spacing +5 added lines, -5 removed lines

@@ -60,22 +60,22 @@ 
             : $pra->getValue()
         ;
         // Checking that the configured comparison type is available
-        if(!isset($this->comparisons[$pra->getComparisonType()])) {
+        if (!isset($this->comparisons[$pra->getComparisonType()])) {
             throw new \InvalidArgumentException('The requested comparison class does not exist');
         }
         // The comparison class will perform the attribute check with the configured method
         // For more complex comparisons, the comparison manager is injected
         $comparison = new $this->comparisons[$pra->getComparisonType()]($this);
-        if(!method_exists($comparison, $pra->getComparison())) {
+        if (!method_exists($comparison, $pra->getComparison())) {
             throw new \InvalidArgumentException('The requested comparison method does not exist');
         }
         // Then the comparison is performed with needed
         $result = $comparison->{$pra->getComparison()}($praValue, $attribute->getValue(), $pra->getExtraData());
         // If the checked attribute is not valid, the attribute slug is marked as rejected
         // The rejected attributes will be returned instead of the expected true boolean
-        if($result !== true) {
+        if ($result !== true) {
             // In case of sub comparing, the error reporting is disabled
-            if(!in_array($attribute->getSlug(), $this->rejectedAttributes) && $subComparing === false) {
+            if (!in_array($attribute->getSlug(), $this->rejectedAttributes) && $subComparing === false) {
                 $this->rejectedAttributes[] = $attribute->getSlug();
             }
             return false;
@@ -102,7 +102,7 @@ 
      * @throws \InvalidArgumentException
      */
     public function getDynamicAttribute($attributeSlug) {
-        if(!isset($this->dynamicAttributes[$attributeSlug])) {
+        if (!isset($this->dynamicAttributes[$attributeSlug])) {
             throw new \InvalidArgumentException("The dynamic value for attribute $attributeSlug was not given");
         }
         return $this->dynamicAttributes[$attributeSlug];

src/Comparison/ArrayComparison.php

Spacing +4 added lines, -4 removed lines

@@ -55,23 +55,23 @@
      * @return boolean
      */
     public function contains($policyRuleAttributes, $attributes, $extraData = []) {
-        foreach($extraData['attribute']->getValue() as $attribute) {
+        foreach ($extraData['attribute']->getValue() as $attribute) {
             $result = true;
             // For each attribute, we check the whole rules set
-            foreach($policyRuleAttributes as $pra) {
+            foreach ($policyRuleAttributes as $pra) {
                 $attributeData = $pra->getAttribute();
                 $attributeData->setValue(
                     $this->comparisonManager->getAttributeManager()->retrieveAttribute($attributeData, $extraData['user'], $attribute)
                 );
                 // If one field is not matched, the whole attribute is rejected
-                if(!$this->comparisonManager->compare($pra, true)) {
+                if (!$this->comparisonManager->compare($pra, true)) {
                     //var_dump($attributeData->getName(), $attributeData->getValue(), $pra->getValue());
                     $result = false;
                     break;
                 }
             }
             // If the result is still true at the end of the attribute check, the rule is enforced
-            if($result === true) {
+            if ($result === true) {
                 return true;
             }
         }

src/Cache/Item/TextCacheItem.php

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
      * {@inheritdoc}
      */
     public function get() {
-        if(!$this->isHit()) {
+        if (!$this->isHit()) {
             throw new ExpiredCacheException('Cache item is expired');
         }
         return $this->value;

src/Cache/Pool/TextCacheItemPool.php

Spacing +12 added lines, -12 removed lines

@@ -27,7 +27,7 @@ 
         $this->cacheFolder =
             (isset($options['cache_folder']))
             ? "{$options['cache_folder']}/text"
-            : __DIR__ . '/../../../data/cache/text'
+            : __DIR__.'/../../../data/cache/text'
         ;
     }
 
@@ -35,10 +35,10 @@ 
      * {@inheritdoc}
      */
     public function deleteItem($key) {
-        if(is_file("{$this->cacheFolder}/$key.txt")) {
+        if (is_file("{$this->cacheFolder}/$key.txt")) {
             unlink("{$this->cacheFolder}/$key.txt");
         }
-        if(isset($this->deferredItems[$key])) {
+        if (isset($this->deferredItems[$key])) {
             unset($this->deferredItems[$key]);
         }
         return true;
@@ -48,8 +48,8 @@ 
      * {@inheritdoc}
      */
     public function deleteItems(array $keys) {
-        foreach($keys as $key) {
-            if(!$this->deleteItem($key)) {
+        foreach ($keys as $key) {
+            if (!$this->deleteItem($key)) {
                 return false;
             }
         }
@@ -80,7 +80,7 @@ 
      * {@inheritdoc}
      */
     public function commit() {
-        foreach($this->deferredItems as $key => $item) {
+        foreach ($this->deferredItems as $key => $item) {
             $this->save($item);
             unset($this->deferredItems[$key]);
         }
@@ -99,10 +99,10 @@ 
      */
     public function getItem($key) {
         $item = new TextCacheItem($key);
-        if(!$this->hasItem($key)) {
+        if (!$this->hasItem($key)) {
             return $item;
         }
-        $data = explode(';',file_get_contents("{$this->cacheFolder}/{$key}.txt"));
+        $data = explode(';', file_get_contents("{$this->cacheFolder}/{$key}.txt"));
         return $item
             ->set($data[0])
             ->expiresAt((new \DateTime($data[1])))
@@ -114,8 +114,8 @@ 
      */
     public function getItems(array $keys = array()) {
         $items = [];
-        foreach($keys as $key) {
-            if($this->hasItem($key)) {
+        foreach ($keys as $key) {
+            if ($this->hasItem($key)) {
                 $items[$key] = $this->getItem($key);
             }
         }
@@ -127,8 +127,8 @@ 
      */
     public function clear() {
         $items = glob("{$this->cacheFolder}/*.txt"); // get all file names
-        foreach($items as $item){ // iterate files
-          if(is_file($item))
+        foreach ($items as $item) { // iterate files
+          if (is_file($item))
             unlink($item); // delete file
         }
         $this->deferredItems = [];

example/User.php

Doc Comments +1 added lines, -2 removed lines

@@ -82,7 +82,7 @@ 
     }
     
     /**
-     * @return bool
+     * @return string
      */
     public function getParentNationality() {
         return $this->parentNationality;
@@ -119,7 +119,6 @@ 
 	/**
 	 * Return a specific visa
 	 *
-	 * @param Visa $visa
 	 *
 	 * @return mixed|null
 	 */

Spacing +2 added lines, -2 removed lines

@@ -103,7 +103,7 @@ 
      * @return \PhpAbac\Example\User
      */
     public function removeVisa(Visa $visa) {
-        if(isset($this->visas[$visa->getId()])) {
+        if (isset($this->visas[$visa->getId()])) {
             unset($this->visas[$visa->getId()]);
         }
         return $this;
@@ -126,7 +126,7 @@ 
     public function getVisa($country_code) {
     	/** @var Visa $visa */
     	$visas = [];
-		foreach($this->visas as $visa) {
+		foreach ($this->visas as $visa) {
     		if ($visa->getCountry()->getCode() == $country_code)
 				$visas[] = $visa;
 		}

src/Loader/AbacLoader.php

Doc Comments +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
 	 * Method to check if a resource is supported by the loader
 	 * This method check only extension file
 	 *
-	 * @param $resource
+	 * @param string $resource
 	 *
 	 * @return boolean Return true if the extension of the ressource is supported by the loader
 	 */

Spacing +5 added lines, -5 removed lines

@@ -21,8 +21,8 @@ 
 	/** @var  ConfigurationManager The configuration manage instanciator and user of this AbacLoader Instance */
 	protected $configurationManger;
 	
-	public function __construct( FileLocatorInterface $locator ) {
-		parent::__construct( $locator );
+	public function __construct(FileLocatorInterface $locator) {
+		parent::__construct($locator);
 	}
 	
 	/**
@@ -33,7 +33,7 @@ 
 	 *
 	 * @return string
 	 */
-	abstract public function load( $resource, $type = null );
+	abstract public function load($resource, $type = null);
 	
 //	/**
 //	 * Method to check if a resource ( by his path ) is supported by the loader
@@ -53,8 +53,8 @@ 
 	 *
 	 * @return boolean Return true if the extension of the ressource is supported by the loader
 	 */
-	public static final function supportsExtension( $resource ) {
-		return in_array( pathinfo( $resource, PATHINFO_EXTENSION ), self::getExtensionAllowed() );
+	public static final function supportsExtension($resource) {
+		return in_array(pathinfo($resource, PATHINFO_EXTENSION), self::getExtensionAllowed());
 	}
 
     /**