PhpAbac\Comparison\ArrayComparison

Complexity

Total Complexity

9

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	isIn()	0	4	1
A	isNotIn()	0	4	1
A	intersect()	0	4	1
A	doNotIntersect()	0	4	1
B	contains()	0	23	5

<?php

namespace PhpAbac\Comparison;

class ArrayComparison extends AbstractComparison
{
    /**
     * @param array $haystack
     * @param mixed  $needle
     *
     * @return bool
     */
    public function isIn($haystack, $needle)
    {
        return in_array($needle, $haystack);
    }

    /**
     * @param array $haystack
     * @param mixed  $needle
     *
     * @return bool
     */
    public function isNotIn($haystack, $needle)
    {
        return !$this->isIn($haystack, $needle);
    }

    /**
     * @param array $array1
     * @param array $array2
     *
     * @return bool
     */
    public function intersect($array1, $array2)
    {
        return count(array_intersect($array1, $array2)) > 0;
    }

    /**
     * @param array $array1
     * @param array $array2
     *
     * @return bool
     */
    public function doNotIntersect($array1, $array2)
    {
        return !$this->intersect($array1, $array2);
    }

    /**
     * @param array $policyRuleAttributes
     * @param array $attributes
     * @param array $extraData
     * @return boolean
     */
    public function contains($policyRuleAttributes, $attributes, $extraData = []) {

The parameter $attributes is not used and could be removed.

        foreach($extraData['attribute']->getValue() as $attribute) {

Expected 1 space after FOREACH keyword; 0 found

            $result = true;
            // For each attribute, we check the whole rules set
            foreach($policyRuleAttributes as $pra) {

Expected 1 space after FOREACH keyword; 0 found

                $attributeData = $pra->getAttribute();
                $attributeData->setValue(
                    $this->comparisonManager->getAttributeManager()->retrieveAttribute($attributeData, $extraData['user'], $attribute)
                );
                // If one field is not matched, the whole attribute is rejected
                if(!$this->comparisonManager->compare($pra, true)) {

Expected 1 space after IF keyword; 0 found

                    //var_dump($attributeData->getName(), $attributeData->getValue(), $pra->getValue());
                    $result = false;
                    break;
                }
            }
            // If the result is still true at the end of the attribute check, the rule is enforced
            if($result === true) {

Expected 1 space after IF keyword; 0 found

                return true;
            }
        }
        return false;
    }
}