Flysystem2Storage::__construct() - Code Metrics - Inspection of "Add Flysystem 2 Storage" - Kevinrob/guzzle-cache-middleware - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#138)

unknown

created 2021-02-03 15:24 UTC

Flysystem2Storage::__construct() A

↳ Parent: Flysystem2Storage

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	4
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	4
loc	4
ccs	0
cts	3
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	2

<?php

namespace Kevinrob\GuzzleCache\Storage;

use Kevinrob\GuzzleCache\CacheEntry;
use League\Flysystem\Local\LocalFilesystemAdapter;
use League\Flysystem\Filesystem;
use League\Flysystem\FileNotFoundException;

class Flysystem2Storage implements CacheStorageInterface

{

    /**
     * @var Filesystem
     */
    protected $filesystem;

    public function __construct(LocalFilesystemAdapter $adapter)
    {
        $this->filesystem = new Filesystem($adapter);
    }

    /**
     * @inheritdoc
     */
    public function fetch($key)
    {
        if ($this->filesystem->fileExists($key)) {
            // The file exist, read it!
            $data = @unserialize(
                $this->filesystem->read($key)
            );

            if ($data instanceof CacheEntry) {
                return $data;
            }
        }

        return;
    }

    /**
     * @inheritdoc
     */
    public function save($key, CacheEntry $data)
    {
        return $this->filesystem->write($key, serialize($data));
    }

    /**
     * {@inheritdoc}
     */
    public function delete($key)
    {
        try {
            return $this->filesystem->delete($key);
        } catch (FileNotFoundException $ex) {
            return true;
        }
    }
}


1		<?php
2
3		namespace Kevinrob\GuzzleCache\Storage;
4
5		use Kevinrob\GuzzleCache\CacheEntry;
6		use League\Flysystem\Local\LocalFilesystemAdapter;
7		use League\Flysystem\Filesystem;
8		use League\Flysystem\FileNotFoundException;
9
10	View Code Duplication	class Flysystem2Storage implements CacheStorageInterface
		0 ignored issues – show Duplication introduced 2021-02-03 15:27 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11		{
12
13		/**
14		* @var Filesystem
15		*/
16		protected $filesystem;
17
18		public function __construct(LocalFilesystemAdapter $adapter)
19		{
20		$this->filesystem = new Filesystem($adapter);
21		}
22
23		/**
24		* @inheritdoc
25		*/
26		public function fetch($key)
27		{
28		if ($this->filesystem->fileExists($key)) {
29		// The file exist, read it!
30		$data = @unserialize(
31		$this->filesystem->read($key)
32		);
33
34		if ($data instanceof CacheEntry) {
35		return $data;
36		}
37		}
38
39		return;
40		}
41
42		/**
43		* @inheritdoc
44		*/
45		public function save($key, CacheEntry $data)
46		{
47		return $this->filesystem->write($key, serialize($data));
48		}
49
50		/**
51		* {@inheritdoc}
52		*/
53		public function delete($key)
54		{
55		try {
56		return $this->filesystem->delete($key);
57		} catch (FileNotFoundException $ex) {
58		return true;
59		}
60		}
61		}
62

Kevinrob / guzzle-cache-middleware

Pull Request — master (#138)

Flysystem2Storage::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like