Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
23 | class PrefixedTranslator extends Nette\Object implements ITranslator |
||
24 | { |
||
25 | |||
26 | /** |
||
27 | * @var \Nette\Localization\ITranslator |
||
28 | */ |
||
29 | private $translator; |
||
30 | |||
31 | /** |
||
32 | * @var string |
||
33 | */ |
||
34 | private $prefix; |
||
35 | |||
36 | |||
37 | |||
38 | /** |
||
39 | * @param string $prefix |
||
40 | * @param ITranslator $translator |
||
41 | */ |
||
42 | public function __construct($prefix, ITranslator $translator) |
||
51 | |||
52 | |||
53 | |||
54 | /** |
||
55 | * @param string $message |
||
56 | * @param int|array|NULL $count |
||
57 | * @param array|string|NULL $parameters |
||
58 | * @param string|NULL $domain |
||
59 | * @param string|NULL $locale |
||
60 | * @return string |
||
61 | */ |
||
62 | public function translate($message, $count = NULL, $parameters = [], $domain = NULL, $locale = NULL) |
||
63 | { |
||
64 | $translationString = ($message instanceof Phrase ? $message->message : $message); |
||
65 | $prefix = $this->prefix . '.'; |
||
66 | |||
67 | if (Strings::startsWith($message, '//')) { |
||
68 | $prefix = NULL; |
||
69 | $translationString = Strings::substring($translationString, 2); |
||
70 | } |
||
71 | |||
72 | if ($message instanceof Phrase) { |
||
73 | return $this->translator->translate(new Phrase($prefix . $translationString, $message->count, $message->parameters, $message->domain, $message->locale)); |
||
74 | } |
||
75 | |||
76 | View Code Duplication | if (is_array($count)) { |
|
|
|||
77 | $locale = $domain ?: NULL; |
||
78 | $domain = $parameters ?: NULL; |
||
79 | $parameters = $count ?: []; |
||
80 | $count = NULL; |
||
81 | } |
||
82 | |||
83 | return $this->translator->translate($prefix . $translationString, $count, (array) $parameters, $domain, $locale); |
||
84 | } |
||
85 | |||
86 | |||
87 | |||
88 | /** |
||
89 | * @return ITranslator |
||
90 | */ |
||
91 | public function unwrap() |
||
95 | |||
96 | |||
97 | |||
98 | /** |
||
99 | * @param $template |
||
100 | * @return ITranslator |
||
101 | */ |
||
102 | public function unregister($template) |
||
106 | |||
107 | |||
108 | |||
109 | /** |
||
110 | * @param Latte\Template|\Nette\Bridges\ApplicationLatte\Template|\Nette\Templating\Template $template |
||
111 | * @param string $prefix |
||
112 | * @return ITranslator |
||
113 | * @throws InvalidArgumentException |
||
114 | */ |
||
115 | public static function register($template, $prefix) |
||
120 | |||
121 | |||
122 | |||
123 | /** |
||
124 | * @param Latte\Template|\Nette\Bridges\ApplicationLatte\Template|\Nette\Templating\Template $template |
||
125 | * @param string $prefix |
||
126 | * @return ITranslator |
||
127 | * @throws InvalidArgumentException |
||
128 | */ |
||
129 | public static function register23($template, $prefix) |
||
142 | |||
143 | |||
144 | |||
145 | /** |
||
146 | * @param Latte\Template|Latte\Runtime\Template|\Nette\Bridges\ApplicationLatte\Template|\Nette\Templating\Template $template |
||
147 | * @param ITranslator $translator |
||
148 | */ |
||
149 | private static function overrideTemplateTranslator($template, ITranslator $translator) |
||
163 | |||
164 | } |
||
165 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.