GenerateEntitiesCommand::initialize() - Code Metrics - Inspection of "add new console commands" - Kdyby/Doctrine - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3a90ba...c1951e )

by Filip

created 2017-05-27 02:02 UTC

GenerateEntitiesCommand::initialize() A

↳ Parent: GenerateEntitiesCommand

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	6
rs	9.4285
cc	1
eloc	3
nc	1
nop	2

<?php

/**
 * This file is part of the Kdyby (http://www.kdyby.org)
 *
 * Copyright (c) 2008 Filip Procházka ([email protected])
 *
 * For the full copyright and license information, please view the file license.txt that was distributed with this source code.
 */

namespace Kdyby\Doctrine\Console\Proxy;

use Kdyby\Doctrine\Console\OrmDelegateCommand;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * @author Tomas Jacik <[email protected]>
 */
class GenerateEntitiesCommand extends OrmDelegateCommand
{

	/**
	 * @var \Kdyby\Doctrine\Tools\CacheCleaner
	 * @inject
	 */
	public $cacheCleaner;

	public function __construct()
	{
		parent::__construct();
	}

	protected function initialize(InputInterface $input, OutputInterface $output)
	{
		parent::initialize($input, $output);

		$this->cacheCleaner->invalidate();
	}

	protected function createCommand()
	{
		return new \Doctrine\ORM\Tools\Console\Command\GenerateEntitiesCommand();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
	}

}


1			<?php
2
3			/**
4			* This file is part of the Kdyby (http://www.kdyby.org)
5			*
6			* Copyright (c) 2008 Filip Procházka ([email protected])
7			*
8			* For the full copyright and license information, please view the file license.txt that was distributed with this source code.
9			*/
10
11			namespace Kdyby\Doctrine\Console\Proxy;
12
13			use Kdyby\Doctrine\Console\OrmDelegateCommand;
14			use Symfony\Component\Console\Input\InputInterface;
15			use Symfony\Component\Console\Output\OutputInterface;
16
17			/**
18			* @author Tomas Jacik <[email protected]>
19			*/
20			class GenerateEntitiesCommand extends OrmDelegateCommand
21			{
22
23			/**
24			* @var \Kdyby\Doctrine\Tools\CacheCleaner
25			* @inject
26			*/
27			public $cacheCleaner;
28
29			public function __construct()
30			{
31			parent::__construct();
32			}
33
34			protected function initialize(InputInterface $input, OutputInterface $output)
35			{
36			parent::initialize($input, $output);
37
38			$this->cacheCleaner->invalidate();
39			}
40
41			protected function createCommand()
42			{
43			return new \Doctrine\ORM\Tools\Console\Command\GenerateEntitiesCommand();
			0 ignored issues – show Bug Best Practice introduced 2017-05-27 02:04 UTC by Report Bug Copy Issue Report The return type of `return new \Doctrine\ORM...erateEntitiesCommand();` (`Doctrine\ORM\Tools\Conso...GenerateEntitiesCommand`) is incompatible with the return type declared by the abstract method `Kdyby\Doctrine\Console\O...eCommand::createCommand` of type `Symfony\Component\Console\Command\Command`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
44			}
45
46			}
47

Kdyby / Doctrine

Push — master ( 3a90ba...c1951e )

GenerateEntitiesCommand::initialize() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like