Completed
Push — master ( 3a90ba...c1951e )
by Filip
02:11
created

CacheClearQueryCommand::createCommand()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 4
Code Lines 2

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
c 0
b 0
f 0
dl 0
loc 4
rs 10
cc 1
eloc 2
nc 1
nop 0
1
<?php
2
3
/**
4
 * This file is part of the Kdyby (http://www.kdyby.org)
5
 *
6
 * Copyright (c) 2008 Filip Procházka ([email protected])
7
 *
8
 * For the full copyright and license information, please view the file license.txt that was distributed with this source code.
9
 */
10
11
namespace Kdyby\Doctrine\Console\Proxy;
12
13
use Doctrine\ORM\Tools\Console\Command\ClearCache\QueryCommand;
14
use Kdyby\Doctrine\Console\OrmDelegateCommand;
15
16
/**
17
 * Command to clear the query cache of the various cache drivers.
18
 */
19
class CacheClearQueryCommand extends OrmDelegateCommand
20
{
21
22
	protected function createCommand()
23
	{
24
		return new QueryCommand();
0 ignored issues
show
Bug Best Practice introduced by
The return type of return new \Doctrine\ORM...arCache\QueryCommand(); (Doctrine\ORM\Tools\Conso...ClearCache\QueryCommand) is incompatible with the return type declared by the abstract method Kdyby\Doctrine\Console\O...eCommand::createCommand of type Symfony\Component\Console\Command\Command.

If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design.

Let’s take a look at an example:

class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}

Our function my_function expects a Post object, and outputs the author of the post. The base class Post returns a simple string and outputting a simple string will work just fine. However, the child class BlogPost which is a sub-type of Post instead decided to return an object, and is therefore violating the SOLID principles. If a BlogPost were passed to my_function, PHP would not complain, but ultimately fail when executing the strtoupper call in its body.

Loading history...
25
	}
26
27
}
28