Issues in Money.php (master) - Issues in master - Kanunak/money - Measure and Improve Code Quality continuously with Scrutinizer

Issues (2)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Money/Money.php (2 issues)

Labels

Duplication 2

Severity

Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kanunak\Money;

class Money
{
    const NUMBER_OF_DECIMALS = 4;

    /** @var  Currency */
    private $currency;

    /** @var  int */
    private $value;

    /**
     * @param Currency $currency
     * @param int $value
     */
    public function __construct(Currency $currency, $value)
    {
        $this->validateValue($value);
        $this->currency = $currency;
        $this->value = $value;
    }

    /**
     * @return Currency
     */
    public function currency()
    {
        return $this->currency;
    }

    /**
     * @return int
     */
    public function value()
    {
        return $this->value;
    }

    /**
     * @return int
     */
    public function decimals()
    {
        return self::NUMBER_OF_DECIMALS;
    }

    /**
     * @param Money $moneyToAdd
     * @return Money
     * @throw \InvalidArgumentException
     */
    public function add(Money $moneyToAdd)

    {
        if (!$this->isSameCurrency($moneyToAdd)) {
            throw new \InvalidArgumentException('Currencies does not match');
        }
        return new Money($this->currency(), $this->value() + $moneyToAdd->value());
    }

    /**
     * @param Money $moneyToSubtract
     * @return Money
     * @throw \InvalidArgumentException
     */
    public function subtract(Money $moneyToSubtract)

    {
        if (!$this->isSameCurrency($moneyToSubtract)) {
            throw new \InvalidArgumentException('Currencies does not match');
        }
        return new Money($this->currency(), $this->value() - $moneyToSubtract->value());
    }

    /**
     * @param Money $moneyToCompare
     * @return bool
     * @throw \InvalidArgumentException
     */
    public function equals(Money $moneyToCompare)
    {
        if ($this->isSameCurrency($moneyToCompare)) {
            return $this->value() === $moneyToCompare->value();
        }
        return false;
    }

    /**
     * @param CurrencyPair $currencyPair
     * @return Money
     * @throw \InvalidArgumentException
     */
    public function exchange(CurrencyPair $currencyPair)
    {
        if (!$this->isSameCurrencyInCurrencyPair($currencyPair)) {
            throw new \InvalidArgumentException('CurrencyFrom in the CurrencyPair does not match the money currency');
        }
        return new Money($currencyPair->currencyTo(), (int)($this->value() * $currencyPair->ratio()));
    }

    /**
     * @param CurrencyPair $currencyPair
     * @return bool
     */
    private function isSameCurrencyInCurrencyPair(CurrencyPair $currencyPair)
    {
        return ($this->currency()->equals($currencyPair->currencyFrom()));
    }

    /**
     * @param Money $money
     * @return bool
     */
    private function isSameCurrency(Money $money)
    {
        return ($this->currency()->equals($money->currency()));
    }

    /**
     * @param $value
     * @thrown \InvalidArgumentException
     */
    private function validateValue($value)
    {
        if (!is_integer($value)) {
            throw new \InvalidArgumentException('Provided value is not an integer: '.$value);
        }
    }
}


1		<?php
2
3		namespace Kanunak\Money;
4
5		class Money
6		{
7		const NUMBER_OF_DECIMALS = 4;
8
9		/** @var Currency */
10		private $currency;
11
12		/** @var int */
13		private $value;
14
15		/**
16		* @param Currency $currency
17		* @param int $value
18		*/
19		public function __construct(Currency $currency, $value)
20		{
21		$this->validateValue($value);
22		$this->currency = $currency;
23		$this->value = $value;
24		}
25
26		/**
27		* @return Currency
28		*/
29		public function currency()
30		{
31		return $this->currency;
32		}
33
34		/**
35		* @return int
36		*/
37		public function value()
38		{
39		return $this->value;
40		}
41
42		/**
43		* @return int
44		*/
45		public function decimals()
46		{
47		return self::NUMBER_OF_DECIMALS;
48		}
49
50		/**
51		* @param Money $moneyToAdd
52		* @return Money
53		* @throw \InvalidArgumentException
54		*/
55	View Code Duplication	public function add(Money $moneyToAdd)
		0 ignored issues – show Duplication introduced 2015-11-23 15:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
56		{
57		if (!$this->isSameCurrency($moneyToAdd)) {
58		throw new \InvalidArgumentException('Currencies does not match');
59		}
60		return new Money($this->currency(), $this->value() + $moneyToAdd->value());
61		}
62
63		/**
64		* @param Money $moneyToSubtract
65		* @return Money
66		* @throw \InvalidArgumentException
67		*/
68	View Code Duplication	public function subtract(Money $moneyToSubtract)
		0 ignored issues – show Duplication introduced 2015-11-23 15:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
69		{
70		if (!$this->isSameCurrency($moneyToSubtract)) {
71		throw new \InvalidArgumentException('Currencies does not match');
72		}
73		return new Money($this->currency(), $this->value() - $moneyToSubtract->value());
74		}
75
76		/**
77		* @param Money $moneyToCompare
78		* @return bool
79		* @throw \InvalidArgumentException
80		*/
81		public function equals(Money $moneyToCompare)
82		{
83		if ($this->isSameCurrency($moneyToCompare)) {
84		return $this->value() === $moneyToCompare->value();
85		}
86		return false;
87		}
88
89		/**
90		* @param CurrencyPair $currencyPair
91		* @return Money
92		* @throw \InvalidArgumentException
93		*/
94		public function exchange(CurrencyPair $currencyPair)
95		{
96		if (!$this->isSameCurrencyInCurrencyPair($currencyPair)) {
97		throw new \InvalidArgumentException('CurrencyFrom in the CurrencyPair does not match the money currency');
98		}
99		return new Money($currencyPair->currencyTo(), (int)($this->value() * $currencyPair->ratio()));
100		}
101
102		/**
103		* @param CurrencyPair $currencyPair
104		* @return bool
105		*/
106		private function isSameCurrencyInCurrencyPair(CurrencyPair $currencyPair)
107		{
108		return ($this->currency()->equals($currencyPair->currencyFrom()));
109		}
110
111		/**
112		* @param Money $money
113		* @return bool
114		*/
115		private function isSameCurrency(Money $money)
116		{
117		return ($this->currency()->equals($money->currency()));
118		}
119
120		/**
121		* @param $value
122		* @thrown \InvalidArgumentException
123		*/
124		private function validateValue($value)
125		{
126		if (!is_integer($value)) {
127		throw new \InvalidArgumentException('Provided value is not an integer: '.$value);
128		}
129		}
130		}
131

Kanunak / money

Issues (2)

Security Analysis no request data

src/Money/Money.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like