Kalaxia / ScrumbanBundle

Utils/CardHelper.php

<?php

namespace Scrumban\Utils;

use Scrumban\Model\CardInterface;

class CardHelper
{
    public static function extractValue(string $extraData): int
    {
        if (strtoupper($extraData{0}) !== 'V') {
            return 0;
        }
        return (int) substr($extraData, 1, 3);
    }
    
    public static function extractEstimatedTime(string $cardTitle): int

The parameter $cardTitle is not used and could be removed.

    {
        return 0;
    }
    
    public static function extractSpentTime(string $cardTitle): int

The parameter $cardTitle is not used and could be removed.

    {
        return 0;
    }
    
    public static function extractCreationDate(string $cardId): \DateTime
    {
        return (new \DateTime())->setTimestamp(hexdec(substr($cardId, 0, 8)));

It seems like hexdec(substr($cardId, 0, 8)) can also be of type double; however, parameter $unixtimestamp of DateTime::setTimestamp() does only seem to accept integer, maybe add an additional type check?

    }
    
    public static function isInCurrentSprint(string $status): bool
    {
        return in_array($status, [
            CardInterface::STATUS_TODO,
            CardInterface::STATUS_IN_PROGRESS,
            CardInterface::STATUS_REVIEW,
            CardInterface::STATUS_TO_RELEASE
        ]);
    }
    
    public static function slugify($name)
    {
        return str_replace(' ', '_', strtolower($name));
    }
}