Kalaxia / ScrumbanBundle

Manager/UserStoryManager.php

<?php

namespace Scrumban\Manager;

use Scrumban\Entity\UserStory;
use Scrumban\Entity\Sprint;

use Doctrine\Common\Persistence\ObjectManager;

use Scrumban\Event\UserStoryCreationEvent;
use Scrumban\Event\UserStoryUpdateEvent;

use Symfony\Component\EventDispatcher\EventDispatcherInterface;

final class UserStoryManager
{
    /** @var ObjectManager **/
    private $om;
    /** @var EventDispatcherInterface **/
    private $eventDispatcher;
    
    public function __construct(ObjectManager $om, EventDispatcherInterface $eventDispatcher)
    {
        $this->om = $om;
        $this->eventDispatcher = $eventDispatcher;
    }
    
    public function createUserStory(string $id, string $title, string $description, string $value, string $status, float $estimatedTime, float $spentTime, \DateTime $createdAt, Sprint $sprint = null): UserStory
    {
        $userStory =
            (new UserStory())
            ->setId($id)
            ->setTitle($title)
            ->setDescription($description)
            ->setValue($value)

$value of type string is incompatible with the type integer expected by parameter $value of Scrumban\Model\UserStory::setValue().

            ->setStatus($status)
            ->setEstimatedTime($estimatedTime)
            ->setSpentTime($spentTime)
            ->setCreatedAt($createdAt)
        ;
        if ($sprint !== null) {
            $userStory->setSprint($sprint);
        }
        $this->om->persist($userStory);
        $this->om->flush();
        $this->eventDispatcher->dispatch(UserStoryCreationEvent::NAME, new UserStoryCreationEvent($userStory));
        return $userStory;
    }
    
    public function updateUserStory(string $id, string $title, string $description, string $value, string $status, float $estimatedTime, float $spentTime, \DateTime $createdAt, Sprint $sprint = null, UserStory $userStory = null)

The parameter $createdAt is not used and could be removed.

The parameter $id is not used and could be removed.

    {
        $userStory
            ->setTitle($title)

The method setTitle() does not exist on null.

            ->setDescription($description)
            ->setValue($value)

$value of type string is incompatible with the type integer expected by parameter $value of Scrumban\Model\UserStory::setValue().

            ->setStatus($status)
            ->setEstimatedTime($estimatedTime)
            ->setSpentTime($spentTime)
        ;
        if ($sprint !== null) {
            $userStory->setSprint($sprint);
        }
        $this->om->flush();
        $this->eventDispatcher->dispatch(UserStoryUpdateEvent::NAME, new UserStoryUpdateEvent($userStory));

It seems like $userStory can also be of type null; however, parameter $userStory of Scrumban\Event\UserStoryUpdateEvent::__construct() does only seem to accept Scrumban\Entity\UserStory, maybe add an additional type check?

    }
    
    public function getAll(): array
    {
        return $this->om->getRepository(UserStory::class)->findAll();
    }
    
    public function getSprintUserStories(Sprint $sprint, array $orderBy = null, int $page = null, int $limit = null): array
    {
        return $this->om->getRepository(UserStory::class)->findBy([
            'sprint' => $sprint
        ], $orderBy, $limit, $page * $limit);
    }
}