KSST / KF

tests/KochTest/Files/DownloadTest.php

<?php

namespace KochTest\Files;

use Koch\Files\Download;
use org\bovigo\vfs\vfsStream;
use org\bovigo\vfs\vfsStreamDirectory;
use org\bovigo\vfs\vfsStreamWrapper;

class DownloadTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var Download
     */
    protected $object;

    /**
     * Sets up the fixture, for example, opens a network connection.
     * This method is called before a test is executed.
     */
    public function setUp()
    {
        include_once __DIR__ . '/../../../framework/Koch/Files/Download.php';
        include_once __DIR__ . '/../../../vendor/autoload.php';

        $this->object = new Download();

        $this->media_files = [

The property media_files does not exist. Did you maybe forget to declare it?

            // type, mime, binarypacks
            ['jpg', 'image/jpeg', [0xffd8, 0xffe0, 0x0010, 0x4a46, 0x4946, 0x0001, 0x0101, 0x0048, 0x0048]],
            ['png', 'image/png', [0x8950, 0x4e47, 0x0d0a, 0x1a0a, 0x0000, 0x000d, 0x4948, 0x4452, 0x0000]],
            ['mp4', 'video/mp4', [0x0000, 0x001c, 0x6674, 0x7970, 0x6d70, 0x3432, 0x0000, 0x0000, 0x6973]],
            ['mp3', 'audio/mpeg', [0x4944, 0x3303, 0x0000, 0x0000, 0x1064, 0x5441, 0x4c42, 0x0000, 0x0017]],
            ['avi', 'video/x-msvideo', [0x5249, 0x4646, 0x6a42, 0x0100, 0x4156, 0x4920, 0x4c49, 0x5354, 0x8c05]],
            ['ogg', 'application/ogg', [0x4f67, 0x6753, 0x0002, 0x0000, 0x0000, 0x0000, 0x0000, 0x5d28, 0xf95e]],
            #array("crap", "application/octet-stream", array(0xff09, 0xff08, 0xff07, 0xff06, 0xff05, 0xff04, 0xff03, 0xff02, 0xff01)),

74% of this comment could be valid code. Did you maybe forget this after debugging?

        ];

        vfsStreamWrapper::register();
        $this->root = new vfsStreamDirectory('root');

The property root does not exist. Did you maybe forget to declare it?

        // write virtual files
        foreach ($this->media_files as $mime) {
            // extract inner array structure into variables
            list($type, $mimetype, $binary_pack) = $mime;

$binary_pack does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

The assignment to $mimetype is unused. Consider omitting it like so list($first,,$third).

            $file = 'file.' . $type;
            $file = vfsStream::newFile($file, 0777)->withContent(
                // write binarypacks to file
                call_user_func_array('pack', array_merge(['n*'], (array) $binary_pack))

$binary_pack does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            );
            $this->root->addChild($file);
        }
        vfsStreamWrapper::setRoot($this->root);
    }

    /**
     * Tears down the fixture, for example, closes a network connection.
     * This method is called after a test is executed.
     */
    public function tearDown()
    {
        unset($this->object);
    }

    /**
     * @covers Koch\Files\Download::getMimeType
     */
    public function testGetMimeType()
    {
        foreach ($this->media_files as $mime) {
            // extract inner array structure into variables
            list($type, $mimetype, $binary_pack) = $mime;

$binary_pack does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

The assignment to $binary_pack is unused. Consider omitting it like so list($first,,$third).

            // skip mp3, finfo detects them as "application/octet-stream"
            // instead of "audio/mpeg"
            if ($type === 'mp3') {
                // skip
                continue;
            }

            $vfsFile          = vfsStream::url('root/file.' . $type);
            $fetched_mimetype = $this->object->getMimeType($vfsFile);

$fetched_mimetype does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $this->assertEquals($mimetype, $fetched_mimetype);

$fetched_mimetype does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        }

         // fallback: unknown mimetype is always "application/octet-stream"
         #$file = vfsStream::url('root/file.crap');

55% of this comment could be valid code. Did you maybe forget this after debugging?

         #$this->assertEquals('application/octet-stream', $this->object->getMimeType($file));

77% of this comment could be valid code. Did you maybe forget this after debugging?

    }

    /**
     * @runInSeparateProcess
     * -preserveGlobalState disabled
     * @covers Koch\Files\Download::sendFile
     */
    public function testSendFile()
    {
        $file = __DIR__ . DIRECTORY_SEPARATOR . 'DownloadTest.php';
        $this->object->sendFile($file);

        $this->expectOutputString(file_get_contents($file));
    }
}