framework/Koch/View/Helper/Smarty/function.icon.php ➔ Smarty_function_icon()

Complexity

Conditions	16
Paths	384

Size

Total Lines	94
Code Lines	43

Duplication

Lines	5
Ratio	5.32 %

Importance

Changes

0

<?php
function Smarty_function_icon($params)

function Smarty_function_icon() does not seem to conform to the naming convention (^(?:[a-z]|__)[a-zA-Z0-9]*$).

Smarty_function_icon uses the super-global variable $_SERVER which is generally not recommended.

{
    $src    = '';
    $height = '';
    $alt    = '';
    $name   = '';
    $width  = '';
    $extra  = '';

    /*

50% of this comment could be valid code. Did you maybe forget this after debugging?

      @todo provide usage help text in error message
      if (empty($params['name']) and empty($params['src'])) {
      trigger_error('Provide "name" or "src".', E_USER_ERROR);

      return;
      } */

    extract($params);

    /*
     * if the src attribute contains a http://SERVER_NAME URL its cutted of
     */
    if (isset($src) and empty($src) === false) {

Using logical operators such as and instead of && is generally not recommended.

        $needle = 'http://' . $_SERVER['SERVER_NAME'] . '/';
        $pos    = mb_strpos($src, $needle);
        if ($src !== null and is_int($pos)) {

Using logical operators such as and instead of && is generally not recommended.

            #\Koch\Debug\Debug::printR($pos);

72% of this comment could be valid code. Did you maybe forget this after debugging?

            $src  = mb_substr($src, $pos + mb_strlen($needle));
            $name = basename($src);
        }
    }

    // we have two alternatives :
    // a) src => user has set src, defining the path to the image and imagename
    // b) icondir, name => user has defined the icons dir (relative to core/images folder) and the name of a png file
    // check if it is a valid one
    $icondir_whitelist = ['icons', 'lullacons'];

$icondir_whitelist does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    if ((isset($icondir)) and in_array($icondir, $icondir_whitelist, true)) {

$icondir_whitelist does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

Using logical operators such as and instead of && is generally not recommended.

        // valid
        $icondir .= ''; // leave this. would else be an empty if statement
    } else { // fallback to a valid default
        $icondir = 'icons';
    }

    // transform name into a valid image src
    $src = realpath(APPLICATION_PATH . 'themes/' . 'core/images/' . $icondir . DIRECTORY_SEPARATOR . $name . '.png');

    // if we got no valid src, set a default image
    if (isset($src) and is_file($src) === false) {

Using logical operators such as and instead of && is generally not recommended.

        #$src = WWW_ROOT_THEMES_CORE . 'images/noimage.gif';
        $src  = APPLICATION_PATH . 'themes/' . 'core/images/noimage.gif';
        $name = 'No Image found.' . $src;

$name is not used, you could remove the assignment.

    }

    // we got no height, set it to zero
    if (empty($height)) {
        $height = 0;
    }

    // we got no width, ok then its zero again
    if (empty($width)) {
        $width = 0;
    }

    // we got no height nor width. well let's detect it automatically then.
    if (($height === 0) || ($width === 0)) {

This code seems to be duplicated across your project.

        $currentimagesize = getimagesize($src);
        $width            = $currentimagesize[0];
        $height           = $currentimagesize[1];
    }

    // we got no alternative text. let's add a default text with $name;
    if (($src !== null) and empty($alt)) {

Using logical operators such as and instead of && is generally not recommended.

        $file = $src;

        $info      = pathinfo($file);
        $file_name = basename($file, '.' . $info['extension']);

$file_name does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $alt       = $file_name;

$file_name does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    }

    // no extra attributes to add, then let it be an empty string
    if (empty($extra)) {
        $extra = '';
    }

    // prepare link: transform absolute path into webpath and apply slashfix
    $src = str_replace(APPLICATION_PATH . 'themes/', WWW_ROOT_THEMES, $src);
    $src = str_replace('\\', '/', $src);

    $html = '<img src="' . $src . '" height="' . $height . '" width="'
        . $width . '" alt="' . $alt . '" ' . $extra . ' />';

    return $html;
}