function.columnsort.php ➔ smarty_function_columnsort()

Complexity

Conditions	22
Paths	5790

Size

Total Lines	121
Code Lines	55

Duplication

Lines	15
Ratio	12.4 %

Importance

Changes

0

<?php
function smarty_function_columnsort($params, $smarty)

function smarty_function_columnsort() does not seem to conform to the naming convention (^(?:[a-z]|__)[a-zA-Z0-9]*$).

smarty_function_columnsort uses the super-global variable $_SESSION which is generally not recommended.

{
    $selected_class = null;

$selected_class does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $current_id     = 0;

$current_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $SMCS_id        = 'default';

$SMCS_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    //static $sort_asc_image = null;

50% of this comment could be valid code. Did you maybe forget this after debugging?

    //static $sort_desc_image = null;

50% of this comment could be valid code. Did you maybe forget this after debugging?

    $sort_asc_image  = WWW_ROOT_THEMES_CORE . 'images/icons/asc.png';

$sort_asc_image does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $sort_desc_image = WWW_ROOT_THEMES_CORE . 'images/icons/desc.png';

$sort_desc_image does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    if ($params['cid'] !== null) {

This code seems to be duplicated across your project.

        if ($SMCS_id !== $params['cid']) {

$SMCS_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $current_id = 0;

$current_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        }

        $SMCS_id = $params['cid'];

$SMCS_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    }

    // Retrieve the $_SESSION columnsort object.
    if (!isset($_SESSION['SmartyColumnSort'][$SMCS_id])) {

$SMCS_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        trigger_error('columnsort: SmartyColumnSort.class.php needs to be included for columnsort to work.');

        return;
    }
    $columnsort = $_SESSION['SmartyColumnSort'][$SMCS_id];

$SMCS_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    // HTML
    if (!isset($params['html'])) {
        trigger_error('columnsort: missing "html" parameter.');

        return;
    }

    /*

65% of this comment could be valid code. Did you maybe forget this after debugging?

      if ($params['translate'] != 0) {
      $params['html'] = _($params['html']);
      } */
    $html = $params['html'];

    // selected_class
    if ($params['selected_class'] !== null) {
        $selected_class = $params['selected_class'];

$selected_class does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    }

    // ID for column table
    if ($params['id'] !== null) {

This code seems to be duplicated across your project.

        $id = $params['id'];

        // Increase current id with 1 to prepare for next value
        $current_id = $id + 1;

$current_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$current_id is not used, you could remove the assignment.

    } else {
        $id = $current_id++;

$current_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    }

    /* disabled

51% of this comment could be valid code. Did you maybe forget this after debugging?

      if (($params['asc_image'] !== null) && ($params['desc_image'] !== null)) {
      // Set asc and desc sort images (will be placed after the sorted column)
      $sort_asc_image = $params['asc_image'];
      $sort_desc_image = $params['desc_image'];
      } elseif ($params['asc_image']) || isset($params['desc_image'] !== null) {
      trigger_error('columnsort: Both "asc_image" and "desc_image" needs to be present, or none of them.');
      }
     */

    // alt for image
    if ($params['img_alt'] !== null) {
        $img_alt = $params['img_alt'];

$img_alt does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    } else {
        $img_alt = '';

$img_alt does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    }

    // Get current sort order for current column id
    $sort_order = _smarty_columnsort_sort_order($id, $columnsort['column_array'], $columnsort['default_sort'], $smarty);

$sort_order does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    if ($sort_order === false) {

$sort_order does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        trigger_error('columnsort: too few columns in translate table!');

        return;
    }

    // The column is selected if the get vars exists and is the current column OR
    // if the get vars does not exist and the current column is default.
    if ($columnsort['current_column'] !== null and $columnsort['current_column'] === $id) {

Using logical operators such as and instead of && is generally not recommended.

        $selected = true;
    }

    // Reverse sort order for the output.
    if ($columnsort['current_sort']) {
        $sort_order = mb_strtolower($columnsort['current_sort']) === 'asc' ? 'desc' : 'asc';

$sort_order does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    } elseif ($columnsort['current_column'] === null and $id === $columnsort['default_column']) {

Using logical operators such as and instead of && is generally not recommended.

        $selected = true;

        // Reverse sort order for the output.
        $sort_order = $sort_order === 'asc' ? 'desc' : 'asc';

$sort_order does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    } else {
        $selected = false;
    }

    $columnsort['target_page'] .= (mb_strpos($columnsort['target_page'], '?') !== false ? '&' : '?');

    $url = $columnsort['target_page'] . $columnsort['column_var'] . "=$id&" . $columnsort['sort_var'] . "=$sort_order";

$sort_order does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    // XML compliance patch by Vaccafoeda
    $url = str_replace('&', '&', $url);

    // If asc/desc image exists, append it.
    if ($selected && $sort_asc_image !== null) {

$sort_asc_image does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

The variable $selected does not seem to be defined for all execution paths leading up to this point.

        $image_src = $sort_order === 'asc' ? $sort_desc_image : $sort_asc_image;

$image_src does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $image     = " <img src=\"$image_src\" alt=\"$img_alt\" border=\"0\" />";

$image_src does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    } else {
        $image = '';
    }

    $class = $selected && $selected_class ? "class=\"$selected_class\"" : '';

$selected_class does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $result = '<a ' . $class . ' href="' . $url . '>' .
        '<span style="width:100%;padding:0px;margin:0px;text-align:center;">' .
        $html . ' ' . $image . '</span></a>';

    return $result;
}