Kobas::checkResponse() - Code Metrics - Inspection of "Adding the composer.lock seems to have added more..." - KOBASSoftware/oauth2-kobas - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7bcb82...e6fc4f )

by Sean

created 2018-10-09 23:40 UTC

Kobas::checkResponse() A

↳ Parent: Kobas

Complexity

Conditions	3
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	9
cts	9
cp	1
rs	9.9
c	0
b	0
f	0
cc	3
nc	2
nop	2
crap	3

<?php

namespace Kobas\OAuth2\Client\Provider;

use League\OAuth2\Client\Provider\AbstractProvider;
use League\OAuth2\Client\Provider\Exception\IdentityProviderException;
use League\OAuth2\Client\Token\AccessToken;
use League\OAuth2\Client\Tool\BearerAuthorizationTrait;
use Psr\Http\Message\ResponseInterface;

class Kobas extends AbstractProvider
{
    use BearerAuthorizationTrait;
    /**
     * Default scopes
     *
     * @var array
     */
    public $defaultScopes = ['integration'];

    /**
     * Kobas OAuth URL
     *
     * @var string
     */
    public $url = 'https://oauth.kobas.co.uk';

    /**
     * Kobas Company ID
     *
     * @var int
     */
    public $companyId;

    /**
     * Get authorization url to begin OAuth flow
     *
     * @return string
     */
    public function getBaseAuthorizationUrl()
    {
        return $this->url . '/authorize';
    }


    /**
     * Get access token url to retrieve token
     *
     * @return string
     */
    public function getBaseAccessTokenUrl(array $params)
    {
        return $this->url . '/access_token?x-kobas-company-id=' . $this->companyId;
    }

    /**
     * Get provider url to fetch user details
     *
     * @param  AccessToken $token
     *
     * @return string
     */
    public function getResourceOwnerDetailsUrl(AccessToken $token)
    {
        return $this->url . '/me';
    }

    /**
     * Get the default scopes used by this provider.
     *
     * This should not be a complete list of all scopes, but the minimum
     * required for the provider user interface!
     *
     * @return array
     */
    protected function getDefaultScopes()
    {
        return $this->defaultScopes;
    }

    /**
     * Returns the string that should be used to separate scopes when building
     * the URL for requesting an access token.
     *
     * @return string Scope separator, defaults to ' '
     */
    protected function getScopeSeparator()
    {
        return ' ';
    }

    /**
     * Check a provider response for errors.
     *
     * @throws IdentityProviderException
     * @param  ResponseInterface $response
     * @param  string $data Parsed response data
     * @return void
     */
    protected function checkResponse(ResponseInterface $response, $data)
    {
        $acceptableStatuses = [200, 201];
        if (!in_array($response->getStatusCode(), $acceptableStatuses)) {
            throw new IdentityProviderException(
                $data['message'] ?: $response->getReasonPhrase(),
                $response->getStatusCode(),
                $response
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            );
        }
    }

    /**
     * Generate a user object from a successful user details request.
     *
     * @param object $response
     * @param AccessToken $token
     * @return KobasResourceOwner
     */
    protected function createResourceOwner(array $response, AccessToken $token)
    {
        return new KobasResourceOwner($response);
    }
}


1		<?php
2
3		namespace Kobas\OAuth2\Client\Provider;
4
5		use League\OAuth2\Client\Provider\AbstractProvider;
6		use League\OAuth2\Client\Provider\Exception\IdentityProviderException;
7		use League\OAuth2\Client\Token\AccessToken;
8		use League\OAuth2\Client\Tool\BearerAuthorizationTrait;
9		use Psr\Http\Message\ResponseInterface;
10
11		class Kobas extends AbstractProvider
12		{
13		use BearerAuthorizationTrait;
14		/**
15		* Default scopes
16		*
17		* @var array
18		*/
19		public $defaultScopes = ['integration'];
20
21		/**
22		* Kobas OAuth URL
23		*
24		* @var string
25		*/
26		public $url = 'https://oauth.kobas.co.uk';
27
28		/**
29		* Kobas Company ID
30		*
31		* @var int
32		*/
33		public $companyId;
34
35		/**
36		* Get authorization url to begin OAuth flow
37		*
38		* @return string
39		*/
40	9	public function getBaseAuthorizationUrl()
41		{
42	9	return $this->url . '/authorize';
43		}
44
45
46		/**
47		* Get access token url to retrieve token
48		*
49		* @return string
50		*/
51	15	public function getBaseAccessTokenUrl(array $params)
52		{
53	15	return $this->url . '/access_token?x-kobas-company-id=' . $this->companyId;
54		}
55
56		/**
57		* Get provider url to fetch user details
58		*
59		* @param AccessToken $token
60		*
61		* @return string
62		*/
63	6	public function getResourceOwnerDetailsUrl(AccessToken $token)
64		{
65	6	return $this->url . '/me';
66		}
67
68		/**
69		* Get the default scopes used by this provider.
70		*
71		* This should not be a complete list of all scopes, but the minimum
72		* required for the provider user interface!
73		*
74		* @return array
75		*/
76	6	protected function getDefaultScopes()
77		{
78	6	return $this->defaultScopes;
79		}
80
81		/**
82		* Returns the string that should be used to separate scopes when building
83		* the URL for requesting an access token.
84		*
85		* @return string Scope separator, defaults to ' '
86		*/
87	9	protected function getScopeSeparator()
88		{
89	9	return ' ';
90		}
91
92		/**
93		* Check a provider response for errors.
94		*
95		* @throws IdentityProviderException
96		* @param ResponseInterface $response
97		* @param string $data Parsed response data
98		* @return void
99		*/
100	12	protected function checkResponse(ResponseInterface $response, $data)
101		{
102	12	$acceptableStatuses = [200, 201];
103	12	if (!in_array($response->getStatusCode(), $acceptableStatuses)) {
104	3	throw new IdentityProviderException(
105	3	$data['message'] ?: $response->getReasonPhrase(),
106	3	$response->getStatusCode(),
107	2	$response
		0 ignored issues – show Documentation introduced 2018-10-09 22:47 UTC by Report Bug Copy Issue Report `$response` is of type `object<Psr\Http\Message\ResponseInterface>`, but the function expects a `array\|string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
108	1	);
109		}
110	9	}
111
112		/**
113		* Generate a user object from a successful user details request.
114		*
115		* @param object $response
116		* @param AccessToken $token
117		* @return KobasResourceOwner
118		*/
119	3	protected function createResourceOwner(array $response, AccessToken $token)
120		{
121	3	return new KobasResourceOwner($response);
122		}
123		}
124

KOBASSoftware / oauth2-kobas

Push — master ( 7bcb82...e6fc4f )

Kobas::checkResponse() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like