Client::call() - Code Metrics - Inspection of "This API Client now intentionally only works with..." - KOBASSoftware/api-client-php - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#3)

by Sean

created 2018-10-10 01:38 UTC

Client::call() C

↳ Parent: Client

Complexity

Conditions	11
Paths	144

Size

Total Lines	64
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	41
dl	0
loc	64
rs	6.95
c	0
b	0
f	0
cc	11
nc	144
nop	4

How to fix Long Method Complexity

<?php

namespace Kobas\APIClient;

use Kobas\APIClient\Auth\Provider;
use Kobas\APIClient\Exception\CurlException;
use Kobas\APIClient\Exception\HttpException;
use Kobas\APIClient\Request\Curl;
use Kobas\APIClient\Request\HttpRequest;

/**
 * Class Client
 *
 * @package Kobas
 */
class Client
{
    /**
     * @var string
     */
    protected $api_base_url = 'https://api.kobas.co.uk';

    /**
     * @var string
     */
    protected $version = 'v3';

    /**
     * @var Provider
     */
    protected $oAuthProvider;

    /**
     * @var Curl|HttpRequest|null
     */
    protected $request;

    /**
     * @var array
     */
    protected $headers;

    /**
     * @var array
     */
    protected $curl_options;


    /**
     * Client constructor.
     *
     * @param Provider $oAuthProvider
     * @param HttpRequest|null $request
     * @param array $headers
     * @param array $curl_options
     */
    public function __construct(
        Provider $oAuthProvider,
        HttpRequest $request = null,
        $headers = array(),
        $curl_options = array()
    ) {
        $this->oAuthProvider = $oAuthProvider;
        if ($request == null) {
            $request = new Curl();
        }
        $this->request = $request;
        $this->headers = $headers;
        $this->curl_options = $curl_options;
    }

    /**
     * @return string
     */
    public function getApiBaseUrl(): string
    {
        return $this->api_base_url;
    }

    /**
     * @return string
     */
    public function getVersion(): string
    {
        return $this->version;
    }

    /**
     * Allows you to set the API Base URL. Default value is 'https://api.kobas.co.uk'
     *
     * @param $url
     */
    public function setAPIBaseURL($url)
    {
        $this->api_base_url = $url;
    }

    /**
     * Allows you to set the API version to use. Default value is 'v2'
     *
     * @param $version
     */
    public function setAPIVersion($version)
    {
        $this->version = $version;
    }

    /**
     * @param $route
     * @param array $params
     * @param array $headers
     * @return mixed
     * @throws HttpException
     * @throws CurlException
     */
    public function get($route, array $params = array(), array $headers = array())
    {
        return $this->call('GET', $route, $params, $headers);
    }

    /**
     * @param $http_method
     * @param $route
     * @param array $params
     * @param array $headers
     * @return mixed
     * @throws HttpException
     * @throws CurlException
     */
    protected function call($http_method, $route, array $params = array(), array $headers = array())
    {
        $url = $this->api_base_url . '/';
        if (!empty($this->version)) {
            $url .= $this->version . '/';
        }

        $url .= $route;

        $this->request
            ->init()
              init()
            ->setOption(CURLOPT_CUSTOMREQUEST, strtoupper($http_method))
            ->setOption(CURLOPT_RETURNTRANSFER, true)
            ->setOption(CURLOPT_FOLLOWLOCATION, true)
            ->setOption(CURLOPT_ENCODING, '');

        foreach ($this->curl_options as $option => $value) {
            $this->request->setOption($option, $value);
        }

        $headers = array_merge($this->headers, $headers);
        $headers['Authorization'] = "Bearer " . $this->oAuthProvider->getAccessToken();
        $headers['x-kobas-company-id'] = $this->oAuthProvider->getCompanyId();
        $headers['Content-Type'] = 'application/json';

        switch ($http_method) {
            case 'POST':
                $this->request->setOption(CURLOPT_POSTFIELDS, json_encode($params));
                break;
            case 'DELETE':
            case 'PUT':
                $this->request->setOption(CURLOPT_POSTFIELDS, json_encode($params));
                break;
            case 'GET':
                if (count($params)) {
                    $url .= "?" . http_build_query($params);
                }
                break;
        }

        $this->request->setUrl($url);

        $requestHeaders = array();
        foreach ($headers as $key => $value) {
            $requestHeaders[] = $key . ': ' . $value;
        }

        $this->request->setOption(CURLOPT_HTTPHEADER, $requestHeaders);

        $result = $this->request->execute();

        if ($this->request->getErrorNumber()) {
            throw new CurlException($this->request->getErrorMessage(), $this->request->getErrorNumber());
        }

        $last_response = $this->request->getInfo(CURLINFO_HTTP_CODE);

        $this->request->close();

        if ($last_response >= 400) {
            throw new HttpException(json_encode(json_decode($result, true), true), $last_response);
            throw new HttpException(json_encode(json_decode($result, true), /** @scrutinizer ignore-type */ true), $last_response);
        }

        return json_decode($result, true);
    }

    /**
     * @param $route
     * @param array $params
     * @param array $headers
     * @return mixed
     * @throws HttpException
     * @throws CurlException
     */
    public function post($route, array $params = array(), array $headers = array())
    {
        return $this->call('POST', $route, $params, $headers);
    }

    /**
     * @param $route
     * @param array $params
     * @param array $headers
     * @return mixed
     * @throws HttpException
     * @throws CurlException
     */
    public function put($route, array $params = array(), array $headers = array())
    {
        return $this->call('PUT', $route, $params, $headers);
    }

    /**
     * @param $route
     * @param array $params
     * @param array $headers
     * @return mixed
     * @throws HttpException
     * @throws CurlException
     */
    public function delete($route, array $params = array(), array $headers = array())
    {
        return $this->call('DELETE', $route, $params, $headers);
    }

}

KOBASSoftware / api-client-php

GitHub Access Token became invalid

Pull Request — master (#3)

Client::call() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like