KLYgarage /
onesdk
| Conditions | 13 |
| Paths | 11 |
| Total Lines | 38 |
| Code Lines | 28 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 83 | function stream_for($resource = '', array $options = []) |
||
| 84 | { |
||
| 85 | if (is_scalar($resource)) { |
||
| 86 | $stream = fopen('php://temp', 'r+'); |
||
| 87 | if ($resource !== '' && $stream !== false) { |
||
| 88 | fwrite($stream, $resource); |
||
| 89 | fseek($stream, 0); |
||
| 90 | } |
||
| 91 | return new Stream($stream, $options); |
||
|
Bug
introduced
by
|
|||
| 92 | } |
||
| 93 | switch (gettype($resource)) { |
||
| 94 | case 'resource': |
||
| 95 | return new Stream($resource, $options); |
||
| 96 | case 'object': |
||
| 97 | if ($resource instanceof StreamInterface) { |
||
| 98 | return $resource; |
||
| 99 | } elseif ($resource instanceof \Iterator) { |
||
| 100 | return new PumpStream(function () use ($resource) { |
||
| 101 | if (!$resource->valid()) { |
||
| 102 | return false; |
||
| 103 | } |
||
| 104 | $result = $resource->current(); |
||
| 105 | $resource->next(); |
||
| 106 | return $result; |
||
| 107 | }, $options); |
||
| 108 | } elseif (method_exists($resource, '__toString')) { |
||
| 109 | return stream_for((string) $resource, $options); |
||
| 110 | } |
||
| 111 | break; |
||
| 112 | case 'NULL': |
||
| 113 | return new Stream(fopen('php://temp', 'r+'), $options); |
||
| 114 | } |
||
| 115 | |||
| 116 | if (is_callable($resource) && !is_null($resource)) { |
||
| 117 | return new \One\Http\PumpStream($resource, $options); |
||
| 118 | } |
||
| 119 | |||
| 120 | throw new \InvalidArgumentException('Invalid resource type: ' . gettype($resource)); |
||
| 121 | } |
||
| 122 |
Loading history...
